Skip to content

Commit 36f8cef

Browse files
authored
Reworked closureiter transformation. - Convolutedly nested finallies should cause no problems now. - CurrentException state now follows nim runtime rules (pushes and pops appropriately), and mimics normal code, which is somewhat buggy, see #25031 - Previously state optimization (removing empty states or extra jumps) missed some opportunities, I've reimplemented it to do everything possible to optimize the states. At this point any extra states or jumps should be considered a bug. The resulting codegen (compiled binaries) is also slightly smaller. **BUT:** - I had to change C++ reraising logic, see expt.nim. Because with closure iters `currentException` is not always in sync with C++'s notion of current exception. From my tests and understanding of C++ runtime there should not be any problems, but I'm only 99% sure :) - I've reused `nfNoRewrite` flag in one specific case during the transformation. This flag is also used in term-rewriting logic. Again, 99% sure, these 2 scenarios will never intersect.
1 parent fbdc9a4 commit 36f8cef

File tree

6 files changed

+735
-553
lines changed

6 files changed

+735
-553
lines changed

0 commit comments

Comments
 (0)