Merge pull request #23 from flavioheleno/master

nilportugues · web-flow · commit 7ddddbc9f570 · 2017-03-13T16:47:01.000+01:00
Avoid calling lastInsertId on entity updates
diff --git a/src/Infrastructure/Model/Repository/Sql/SqlWriteRepository.php b/src/Infrastructure/Model/Repository/Sql/SqlWriteRepository.php
@@ -43,12 +43,14 @@ public function add(Identity $value)
     {
         try {
             $this->updateQuery($value);
+            $insert = false;
         } catch (PDOException $e) {
             $this->insertQuery($value);
+            $insert = true;
         }
 
         $id = $value->id();
-        if ($this->mapping->autoGenerateId()) {
+        if (($insert) && ($this->mapping->autoGenerateId())) {
             $id = $this->queryBuilder()->getConnection()->lastInsertId();
         }
 

Original file line number	Diff line number	Diff line change
`@@ -43,12 +43,14 @@ public function add(Identity $value)`
`43`	`43`	`{`
`44`	`44`	`try {`
`45`	`45`	`$this->updateQuery($value);`
	`46`	`+ $insert = false;`
`46`	`47`	`} catch (PDOException $e) {`
`47`	`48`	`$this->insertQuery($value);`
	`49`	`+ $insert = true;`
`48`	`50`	`}`
`49`	`51`
`50`	`52`	`$id = $value->id();`
`51`		`- if ($this->mapping->autoGenerateId()) {`
	`53`	`+ if (($insert) && ($this->mapping->autoGenerateId())) {`
`52`	`54`	`$id = $this->queryBuilder()->getConnection()->lastInsertId();`
`53`	`55`	`}`
`54`	`56`