removing bcrypt.compare from try/catch

Author: nikolovlazar

src/application/use-cases/auth/sign-in.use-case.ts

@@ -30,15 +30,10 @@ export const signInUseCase =
           throw new AuthenticationError('User does not exist');
         }
 
-        let validPassword = false;
-        try {
-          validPassword = await instrumentationService.startSpan(
-            { name: 'verify password hash', op: 'function' },
-            () => compare(input.password, existingUser.password_hash)
-          );
-        } catch (err) {
-          console.error('password hash comparison error', err);
-        }
+        const validPassword = await instrumentationService.startSpan(
+          { name: 'verify password hash', op: 'function' },
+          () => compare(input.password, existingUser.password_hash)
+        );
 
         if (!validPassword) {
           throw new AuthenticationError('Incorrect username or password');

src/application/use-cases/auth/sign-up.use-case.ts

@@ -35,18 +35,10 @@ export const signUpUseCase =
           throw new AuthenticationError('Username taken');
         }
 
-        let passwordHash = '';
-        try {
-          passwordHash = await instrumentationService.startSpan(
-            { name: 'hash password', op: 'function' },
-            () => hash(input.password, PASSWORD_SALT_ROUNDS)
-          );
-        } catch (err) {
-          console.error('password hash error', err);
-          throw new AuthenticationError('Failed to hash password', {
-            cause: err,
-          });
-        }
+        const passwordHash = await instrumentationService.startSpan(
+          { name: 'hash password', op: 'function' },
+          () => hash(input.password, PASSWORD_SALT_ROUNDS)
+        );
 
         const userId = authenticationService.generateUserId();