Fullscreen window and minimize others

[KalbarczykDev]

Hey i use transparent terminal and when i fullscreen a window other windows in the same workspace are still visible

is there option to fullscreen window and minimize other windows

[nikitabobko]

#1424

[MikaelCarpenter]

I've got a branch up for this feature, and I'm bringing it to this discussion in an attempt to keep within the desired CONTRIBUTING.md guidelines, because I have a few questions on implementation before I open the PR.

My two questions are:

1. Is it okay that the layoutRecursive functionality has no tests? If necessary, I can attempt to add some
2. I see the todo regarding moving hideInCorner and unhideFromCorner into layoutRecursive. Now that I'm calling those methods in that file, this feels like the time to move it. Do you agree, or shall I leave that alone for now?

And then not really a question, but if you look at my implementation and would like some edits to names or code style, please let me know. I'd like to conform to the project's style and patterns as much as possible.

Context

I'll first describe my initial naive attempt to add this feature. I saw that MacWindow has hideInCorner and unhideInCorner already. "Wonderful! This will be easy..."

I updated the FullscreenCommand logic to use the new command option to determine whether or not it should call hideInCorner (when fullscreening) or unhideFromCorner (when un-fullscreening). I had written a functionality test for this logic and everything looked good. However in practice, when I tried to use the new command w/ my transparent terminal, I could confirm that the windows were not being hidden.

After some investigation I discovered the refresh logic and the layoutRecursive logic. This made me realize that I was hiding the windows in the command logic, but subsequent layout operations would un-hide them. They are windows in the active workspace so the layout logic was, very reasonably, trying to ensure they stayed visible.

I had attempted to use a new property to mark those hidden windows as isExplicitlyHidden, so that the layout logic wouldn't try to unhide them. However there are times when I DO WANT it to unhide them, like when I have my transparent fullscreen window and I do alt+L to move to the next window, un-fullscreening the original. Trying to figure out how to prevent the layout logic in some scenarios vs others seemed tricky and I knew I was missing something.

This was also when I realized that layoutRecursive is where the real meat of the functionality is, and the FullscreenCommand logic was just manipulating properties on the window. Enter solution v2.

Overview of my implementation

Now I have a property, shouldHideOthersWhileFullscreen, added to Window, similar to how we handle the noOuterGapsInFullscreen. And the fullscreen command logic just updates that property accordingly.

I have a unit test that just looks to verify that the property is set and un-set correctly, but does not assert on the hidden windows. This is because the command logic does not operate on the hidden windows directly.

I updated the logic in layoutRecursive where we handle actually fullscreening the window. I added a branch of logic that says: "If the active window is fullscreen and it has the property that others should be hidden, then call hideInCorner on other windows rather than their normal layout operation".

This hides the windows correctly, and ensures they aren't immediately unhidden by the layout logic, because the fullscreen window is still the most recent one. But when I do alt+L it is no longer the most recent and the layout logic un-hides everything, just like we want! 🎉

NOTE: i'm currently hardcoding the corner to hide them in. I'll update that, but wanted to figure out the answer to question #2 first