[flang] Fix DOT_PRODUCT for logical

klausler · klausler · commit f6aac0dd4d13 · 2021-10-22T15:56:20.000-07:00
A build-time check in a template class instantiation was applying a test that's meaningful only for numeric types. Differential Revision: https://reviews.llvm.org/D112345
diff --git a/flang/runtime/dot-product.cpp b/flang/runtime/dot-product.cpp
@@ -111,7 +111,7 @@ template <TypeCategory RCAT, int RKIND> struct DotProduct {
         if constexpr (constexpr auto resultType{
                           GetResultType(XCAT, XKIND, YCAT, YKIND)}) {
           if constexpr (resultType->first == RCAT &&
-              resultType->second <= RKIND) {
+              (resultType->second <= RKIND || RCAT == TypeCategory::Logical)) {
             return DoDotProduct<RCAT, RKIND, CppTypeFor<XCAT, XKIND>,
                 CppTypeFor<YCAT, YKIND>>(x, y, terminator);
           }

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ template <TypeCategory RCAT, int RKIND> struct DotProduct {`
`111`	`111`	`if constexpr (constexpr auto resultType{`
`112`	`112`	`GetResultType(XCAT, XKIND, YCAT, YKIND)}) {`
`113`	`113`	`if constexpr (resultType->first == RCAT &&`
`114`		`- resultType->second <= RKIND) {`
	`114`	`+ (resultType->second <= RKIND \|\| RCAT == TypeCategory::Logical)) {`
`115`	`115`	`return DoDotProduct<RCAT, RKIND, CppTypeFor<XCAT, XKIND>,`
`116`	`116`	`CppTypeFor<YCAT, YKIND>>(x, y, terminator);`
`117`	`117`	`}`