[flang][NFC] Small refactor for IsProcedurePointer

Daniil Dudkin · Daniil Dudkin · commit 4f1fa558c816 · 2022-06-20T11:10:30.000+03:00
Instead of manually checking for procedure-like details in Symbol, defer it to IsProcedure function. Differential Revision: https://reviews.llvm.org/D127967
diff --git a/flang/lib/Evaluate/tools.cpp b/flang/lib/Evaluate/tools.cpp
@@ -1296,8 +1296,7 @@ const Symbol *FindCommonBlockContaining(const Symbol &original) {
 
 bool IsProcedurePointer(const Symbol &original) {
   const Symbol &symbol{GetAssociationRoot(original)};
-  return IsPointer(symbol) &&
-      (symbol.has<ProcEntityDetails>() || symbol.has<SubprogramDetails>());
+  return IsPointer(symbol) && IsProcedure(symbol);
 }
 
 // 3.11 automatic data object

Original file line number	Diff line number	Diff line change
`@@ -1296,8 +1296,7 @@ const Symbol *FindCommonBlockContaining(const Symbol &original) {`
`1296`	`1296`
`1297`	`1297`	`bool IsProcedurePointer(const Symbol &original) {`
`1298`	`1298`	`const Symbol &symbol{GetAssociationRoot(original)};`
`1299`		`- return IsPointer(symbol) &&`
`1300`		`- (symbol.has<ProcEntityDetails>() \|\| symbol.has<SubprogramDetails>());`
	`1299`	`+ return IsPointer(symbol) && IsProcedure(symbol);`
`1301`	`1300`	`}`
`1302`	`1301`
`1303`	`1302`	`// 3.11 automatic data object`