Skip to content

Commit caf37ca

Browse files
author
Robin Chalas
committed
bug symfony#28664 [Console] Don't return early as this bypasses the auto exit feature (duncan3dc)
This PR was merged into the 3.4 branch. Discussion ---------- [Console] Don't return early as this bypasses the auto exit feature | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | | License | MIT It looks like 8805cfd broke the auto exit feature by returning early. I couldn't find any tests for this feature (presumably because it uses `exit()`), I was going to write one using uopz but didn't want to do this work if Symfony intentionally doesn't test the call to `exit()` Commits ------- b6c17df Don't return early as this bypasses the auto exit feature
2 parents 00efcd4 + b6c17df commit caf37ca

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/Symfony/Component/Console/Application.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,6 @@ public function run(InputInterface $input = null, OutputInterface $output = null
162162
} else {
163163
$exitCode = 1;
164164
}
165-
166-
return $exitCode;
167165
} finally {
168166
// if the exception handler changed, keep it
169167
// otherwise, unregister $renderException

0 commit comments

Comments
 (0)