Skip to content

Commit a6a6dc2

Browse files
minor symfony#28470 Fix symfony/console (optional) dependency for MonologBridge (mpdude)
This PR was merged into the 3.4 branch. Discussion ---------- Fix symfony/console (optional) dependency for MonologBridge | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Since 278c26f, `ConsoleHandler` tries to pass a verbosity level into `Output::write()`. In order to make this work, the change 749fba5 is required which was first released in 2.8.0. When using MonologBridge ^3.3 with a lower version of symfony/console than 2.8, an `InvalidArgumentException` with the message `Unknown output type given` will be thrown. Not sure how to add a test for this... 🤷‍♂️ Commits ------- d6f5d6b Fix symfony/console (optional) dependency for MonologBridge
2 parents 48acf9e + d6f5d6b commit a6a6dc2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/Symfony/Bridge/Monolog/composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,12 @@
2727
"symfony/var-dumper": "~3.3|~4.0"
2828
},
2929
"conflict": {
30+
"symfony/console": "<2.8",
3031
"symfony/http-foundation": "<3.3"
3132
},
3233
"suggest": {
3334
"symfony/http-kernel": "For using the debugging handlers together with the response life cycle of the HTTP kernel.",
34-
"symfony/console": "For the possibility to show log messages in console commands depending on verbosity settings. You need version ~2.3 of the console for it.",
35+
"symfony/console": "For the possibility to show log messages in console commands depending on verbosity settings. You need version ^2.8 of the console for it.",
3536
"symfony/event-dispatcher": "Needed when using log messages in console commands.",
3637
"symfony/var-dumper": "For using the debugging handlers like the console handler or the log server handler."
3738
},

0 commit comments

Comments
 (0)