Skip to content

Commit 99806c5

Browse files
minor symfony#23803 [HttpKernel] Remove isset call used for legacy (ogizanagi)
This PR was merged into the 3.3 branch. Discussion ---------- [HttpKernel] Remove isset call used for legacy | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Added in symfony#9628 in which the request stack dependency was nullable. Forgotten to be removed in symfony#14634. Commits ------- e0a6010 [HttpKernel] Remove isset call used for legacy
2 parents 049785b + e0a6010 commit 99806c5

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,7 @@ public function onKernelTerminate(PostResponseEvent $event)
107107
{
108108
// attach children to parents
109109
foreach ($this->profiles as $request) {
110-
// isset call should be removed when requestStack is required
111-
if (isset($this->parents[$request]) && null !== $parentRequest = $this->parents[$request]) {
110+
if (null !== $parentRequest = $this->parents[$request]) {
112111
if (isset($this->profiles[$parentRequest])) {
113112
$this->profiles[$parentRequest]->addChild($this->profiles[$request]);
114113
}

0 commit comments

Comments
 (0)