Skip to content

Commit 86a9e4a

Browse files
committed
Merge branch '2.8' into 3.4
* 2.8: Fix class documentation [Validator] Add a missing translation Fix phpdocs [EventDispatcher] Remove template method in test case Added LB translation for symfony#27993 (UUID validator message translation) Replace deprecated validateValue with validate
2 parents 60f6e91 + 75eb858 commit 86a9e4a

File tree

6 files changed

+23
-15
lines changed

6 files changed

+23
-15
lines changed

src/Symfony/Component/Console/Command/Command.php

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -369,10 +369,12 @@ public function getNativeDefinition()
369369
/**
370370
* Adds an argument.
371371
*
372-
* @param string $name The argument name
373-
* @param int $mode The argument mode: InputArgument::REQUIRED or InputArgument::OPTIONAL
374-
* @param string $description A description text
375-
* @param mixed $default The default value (for InputArgument::OPTIONAL mode only)
372+
* @param string $name The argument name
373+
* @param int|null $mode The argument mode: self::REQUIRED or self::OPTIONAL
374+
* @param string $description A description text
375+
* @param string|string[]|null $default The default value (for self::OPTIONAL mode only)
376+
*
377+
* @throws InvalidArgumentException When argument mode is not valid
376378
*
377379
* @return $this
378380
*/
@@ -386,11 +388,13 @@ public function addArgument($name, $mode = null, $description = '', $default = n
386388
/**
387389
* Adds an option.
388390
*
389-
* @param string $name The option name
390-
* @param string $shortcut The shortcut (can be null)
391-
* @param int $mode The option mode: One of the InputOption::VALUE_* constants
392-
* @param string $description A description text
393-
* @param mixed $default The default value (must be null for InputOption::VALUE_NONE)
391+
* @param string $name The option name
392+
* @param string|array $shortcut The shortcuts, can be null, a string of shortcuts delimited by | or an array of shortcuts
393+
* @param int|null $mode The option mode: One of the VALUE_* constants
394+
* @param string $description A description text
395+
* @param string|string[]|bool|null $default The default value (must be null for self::VALUE_NONE)
396+
*
397+
* @throws InvalidArgumentException If option mode is invalid or incompatible
394398
*
395399
* @return $this
396400
*/

src/Symfony/Component/EventDispatcher/Tests/GenericEventTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ class GenericEventTest extends TestCase
3131
*/
3232
protected function setUp()
3333
{
34-
parent::setUp();
35-
3634
$this->subject = new \stdClass();
3735
$this->event = new GenericEvent($this->subject, array('name' => 'Event'));
3836
}
@@ -44,8 +42,6 @@ protected function tearDown()
4442
{
4543
$this->subject = null;
4644
$this->event = null;
47-
48-
parent::tearDown();
4945
}
5046

5147
public function testConstruct()

src/Symfony/Component/HttpFoundation/StreamedResponse.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
* A StreamedResponse uses a callback for its content.
1818
*
1919
* The callback should use the standard PHP functions like echo
20-
* to stream the response back to the client. The flush() method
20+
* to stream the response back to the client. The flush() function
2121
* can also be used if needed.
2222
*
2323
* @see flush()

src/Symfony/Component/Validator/Context/ExecutionContextInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public function buildViolation($message, array $parameters = array());
9797
* {
9898
* $validator = $this->context->getValidator();
9999
*
100-
* $violations = $validator->validateValue($value, new Length(array('min' => 3)));
100+
* $violations = $validator->validate($value, new Length(array('min' => 3)));
101101
*
102102
* if (count($violations) > 0) {
103103
* // ...

src/Symfony/Component/Validator/Resources/translations/validators.lb.xlf

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,10 @@
318318
<source>Error</source>
319319
<target>Feeler</target>
320320
</trans-unit>
321+
<trans-unit id="83">
322+
<source>This is not a valid UUID.</source>
323+
<target>Dëst ass keng gëlteg UUID.</target>
324+
</trans-unit>
321325
</body>
322326
</file>
323327
</xliff>

src/Symfony/Component/Validator/Resources/translations/validators.pl.xlf

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,10 @@
318318
<source>Error</source>
319319
<target>Błąd</target>
320320
</trans-unit>
321+
<trans-unit id="83">
322+
<source>This is not a valid UUID.</source>
323+
<target>To nie jest poprawne UUID.</target>
324+
</trans-unit>
321325
</body>
322326
</file>
323327
</xliff>

0 commit comments

Comments
 (0)