Skip to content

Commit 743129f

Browse files
committed
bug symfony#26254 fix custom radios/inputs for checkbox/radio type (mssimi)
This PR was merged into the 3.4 branch. Discussion ---------- fix custom radios/inputs for checkbox/radio type | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | | Fixed tickets | symfony#25715 | License | MIT | Doc PR | Hey, I tried new changes in bootstrap 4 layout. Unfortunatelly custom-radios/checkboxes seems to work only for ChoiceType/EntityType but not for CheckboxType/RadioType. I added changes which I belive fix this issue. Commits ------- dd6d1dd fix custom radios/inputs for checkbox/radio type
2 parents 349f704 + dd6d1dd commit 743129f

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,9 @@
190190
{% block checkbox_radio_label -%}
191191
{#- Do not display the label if widget is not defined in order to prevent double label rendering -#}
192192
{%- if widget is defined -%}
193-
{%- if parent_label_class is defined and ('checkbox-custom' in parent_label_class or 'radio-custom' in parent_label_class) -%}
193+
{% set is_parent_custom = parent_label_class is defined and ('checkbox-custom' in parent_label_class or 'radio-custom' in parent_label_class) %}
194+
{% set is_custom = label_attr.class is defined and ('checkbox-custom' in label_attr.class or 'radio-custom' in label_attr.class) %}
195+
{%- if is_parent_custom or is_custom -%}
194196
{%- set label_attr = label_attr|merge({class: (label_attr.class|default('') ~ ' custom-control-label')|trim}) -%}
195197
{%- else %}
196198
{%- set label_attr = label_attr|merge({class: (label_attr.class|default('') ~ ' form-check-label')|trim}) -%}

0 commit comments

Comments
 (0)