minor symfony#28460 Think positive (umpirsky)

nicolas-grekas · nicolas-grekas · commit 48acf9eef78d · 2018-09-18T14:24:04.000+02:00
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes symfony#28460). Discussion ---------- Think positive | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT No need to invert condition. Commits ------- 0b43738 Think positive
diff --git a/src/Symfony/Component/Lock/Lock.php b/src/Symfony/Component/Lock/Lock.php
@@ -69,10 +69,10 @@ public function __destruct()
     public function acquire($blocking = false)
     {
         try {
-            if (!$blocking) {
-                $this->store->save($this->key);
-            } else {
+            if ($blocking) {
                 $this->store->waitAndSave($this->key);
+            } else {
+                $this->store->save($this->key);
             }
 
             $this->dirty = true;

Original file line number	Diff line number	Diff line change
`@@ -69,10 +69,10 @@ public function __destruct()`
`69`	`69`	`public function acquire($blocking = false)`
`70`	`70`	`{`
`71`	`71`	`try {`
`72`		`- if (!$blocking) {`
`73`		`- $this->store->save($this->key);`
`74`		`- } else {`
	`72`	`+ if ($blocking) {`
`75`	`73`	`$this->store->waitAndSave($this->key);`
	`74`	`+ } else {`
	`75`	`+ $this->store->save($this->key);`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`$this->dirty = true;`