Skip to content

Commit 33ce02e

Browse files
committed
minor symfony#28127 [WebProfilerBundle] Remove useless macro arguments (gregurco)
This PR was merged into the 4.2-dev branch. Discussion ---------- [WebProfilerBundle] Remove useless macro arguments | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I was digging into the Stopwatch Component and the part of displaying timeline in WebProfilerBundle and found some useless arguments in macro. The code was changed but arguments were abandoned. Where the problem appeared: symfony/web-profiler-bundle@bfcc5e7#diff-3651d31bd302da5c7c1ef927e8641c78L294 Commits ------- 70498db [WebProfilerBundle] remove useless macro arguments
2 parents 1c248e5 + 70498db commit 33ce02e

File tree

1 file changed

+6
-6
lines changed
  • src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector

1 file changed

+6
-6
lines changed

src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@
126126
</h3>
127127
{% endif %}
128128

129-
{{ helper.display_timeline('timeline_' ~ token, collector.events, colors) }}
129+
{{ helper.display_timeline('timeline_' ~ token, colors) }}
130130

131131
{% if profile.children|length %}
132132
<p class="help">Note: sections with a striped background correspond to sub-requests.</p>
@@ -140,7 +140,7 @@
140140
<small>{{ events.__section__.duration }} ms</small>
141141
</h4>
142142

143-
{{ helper.display_timeline('timeline_' ~ child.token, events, colors) }}
143+
{{ helper.display_timeline('timeline_' ~ child.token, colors) }}
144144
{% endfor %}
145145
{% endif %}
146146

@@ -470,12 +470,12 @@
470470
var requests_data = {
471471
"max": {{ "%F"|format(collector.events.__section__.endtime) }},
472472
"requests": [
473-
{{ helper.dump_request_data(token, profile, collector.events, collector.events.__section__.origin) }}
473+
{{ helper.dump_request_data(token, collector.events, collector.events.__section__.origin) }}
474474
475475
{% if profile.children|length %}
476476
,
477477
{% for child in profile.children %}
478-
{{ helper.dump_request_data(child.token, child, child.getcollector('time').events, collector.events.__section__.origin) }}{{ loop.last ? '' : ',' }}
478+
{{ helper.dump_request_data(child.token, child.getcollector('time').events, collector.events.__section__.origin) }}{{ loop.last ? '' : ',' }}
479479
{% endfor %}
480480
{% endif %}
481481
]
@@ -513,7 +513,7 @@
513513
//]]>{% endautoescape %}</script>
514514
{% endblock %}
515515

516-
{% macro dump_request_data(token, profile, events, origin) %}
516+
{% macro dump_request_data(token, events, origin) %}
517517
{% autoescape 'js' %}
518518
{% from _self import dump_events %}
519519
{
@@ -549,7 +549,7 @@
549549
{% endautoescape %}
550550
{% endmacro %}
551551

552-
{% macro display_timeline(id, events, colors) %}
552+
{% macro display_timeline(id, colors) %}
553553
<div class="sf-profiler-timeline">
554554
<div class="legends">
555555
{% for category, color in colors %}

0 commit comments

Comments
 (0)