[VarDumper] Use "C" locale when using "comma" flags

nicolas-grekas · nicolas-grekas · commit 305ae5e5d47d · 2017-07-18T18:05:00.000+02:00
diff --git a/src/Symfony/Component/VarDumper/Dumper/AbstractDumper.php b/src/Symfony/Component/VarDumper/Dumper/AbstractDumper.php
@@ -123,6 +123,10 @@ public function setIndentPad($pad)
      */
     public function dump(Data $data, $output = null)
     {
+        if ($locale = $this->flags & (self::DUMP_COMMA_SEPARATOR | self::DUMP_TRAILING_COMMA) ? setlocale(LC_NUMERIC, 0) : null) {
+            setlocale(LC_NUMERIC, 'C');
+        }
+
         if ($returnDump = true === $output) {
             $output = fopen('php://memory', 'r+b');
         }
@@ -143,6 +147,9 @@ public function dump(Data $data, $output = null)
             if ($output) {
                 $this->setOutput($prevOutput);
             }
+            if ($locale) {
+                setlocale(LC_NUMERIC, $locale);
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,10 @@ public function setIndentPad($pad)`
`123`	`123`	`*/`
`124`	`124`	`public function dump(Data $data, $output = null)`
`125`	`125`	`{`
	`126`	`+ if ($locale = $this->flags & (self::DUMP_COMMA_SEPARATOR \| self::DUMP_TRAILING_COMMA) ? setlocale(LC_NUMERIC, 0) : null) {`
	`127`	`+ setlocale(LC_NUMERIC, 'C');`
	`128`	`+ }`
	`129`	`+`
`126`	`130`	`if ($returnDump = true === $output) {`
`127`	`131`	`$output = fopen('php://memory', 'r+b');`
`128`	`132`	`}`
`@@ -143,6 +147,9 @@ public function dump(Data $data, $output = null)`
`143`	`147`	`if ($output) {`
`144`	`148`	`$this->setOutput($prevOutput);`
`145`	`149`	`}`
	`150`	`+ if ($locale) {`
	`151`	`+ setlocale(LC_NUMERIC, $locale);`
	`152`	`+ }`
`146`	`153`	`}`
`147`	`154`	`}`
`148`	`155`