@ngneat/spectator makes google cloud functions predeploy script fail #391
metalllus
started this conversation in
Show and tell
Replies: 2 comments
-
My problem was caused by yarn workspaces - added @types\testing-library__dom\ to nohoist in package.json, and problem solved |
Beta Was this translation helpful? Give feedback.
0 replies
-
I do not use yarn in my project so this is not my case unfortunately I guess... |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
[x] Bug report
After installing @ngneat/spectator package with --save-dev, the predeploy script upon google cloud function deployment fails. I am using Angular 10.0.2 with Jest, Jasmine/Karma was completely removed from the project.
Running command: npm --prefix "functions" run build
../node_modules/@types/testing-library__dom/events.d.ts:86:38 - error TS2304: Cannot find name 'Document'.
86 export type FireFunction = (element: Document | Element | Window | Node, event: Event) => boolean;
../node_modules/@types/testing-library__dom/events.d.ts:86:59 - error TS2304: Cannot find name 'Window'.
86 export type FireFunction = (element: Document | Element | Window | Node, event: Event) => boolean;
I get lots of errors like this when the script fails. this is just a sample.
If I uninstall the package, everything works fine again.
Temporarily removing the node_modules@types\testing-library__dom\ folder added by @ngneat/spectator fixes the issue as well.
Beta Was this translation helpful? Give feedback.
All reactions