Pagination typing

[tklingert]

Hi,

sorry to bother again, I'm trying to wrap my head around generic parameters of the pagination interfaces:

export interface PaginationData<IdType extends number | string = number> {
    total: number;
    perPage: number;
    lastPage: number;
    currentPage: IdType;
}
interface PaginationState<IdType extends number | string = number> {
    pagination: {
        pages: Record<IdType, IdType[]>;
    } & PaginationData<IdType>;
}

Based on my understanding:

• If numeric and textual page notation should be supported:
  • Type of lastPage would then also changed to: IdType
  • State would change to something like:

interface PaginationState<IdType extends number | string = number, IdKey extends PropertyKey> {
    pagination: {
        pages: Record<IdType, IdKey[]>;
    } & PaginationData<IdType>;
}

• If only numeric pages should be supported:
  • PaginationData wouldn't require a generic parameter any more.
  • State would change to something like:

interface PaginationState<IdType extends PropertyKey> {
    pagination: {
        pages: Record<number, IdType[]>;
    } & PaginationData;
}

Atm, I'm paging an object within a string key and e.g.:
store.query(getPaginationData()).pages[1]

• typing: returns number[]
• runtime: string[]