Return a Observable from Effects

[feitzi]

I run into an issue with the correct usage of Effects with elf.

Here is a basic example of my effect:

  public removeUser = this.createEffectFn(($: Observable<number>) =>
    $.pipe(
      switchMap(id => this.client.deleteUser(id).pipe(map(() => id))),
      tap(id => userStore.update(deleteEntities(id)))
    )
  );

Then i use it elsewhere like that:

 this.repository.removeUser(userId);
// how can i handle the successful removal of the user?

Now in the usage of the effect I have no observable to reuse. In this example, I want to redirect the user to another page. But i don't want to do that directly in the effect because I want to decide that in the usage of the effect.

I'm looking for something like that:

 var deletionEffect$ = this.repository.removeUser(userId);
 deletionEffect$.subscribe(() => 
      // do something after the effect is complete
    );
// how can i handle the successful removal of the user?

Can anyone help?

[NetanelBasal]

Can you explain why it could not be in the effect?

[NetanelBasal]

You can even pass a success function:

 var deletionEffect$ = this.repository.removeUser({ userId, successFn } );

[feitzi]

That will work, but it looks a little like a hack.
I'm coming from NGXS, and there you get an observable from dispatch NGXS Docu:

Let's say after the action executes you want to clear the form. Our dispatch function actually returns an Observable, so we can subscribe to it and reset the form after it was successful.

Are there any reasons why Elf don't return an observable from dispatching an action (or effect)

[NetanelBasal]

No

[feitzi]

Is there any way to add such a function? I can also create a PR if this function is useful for Elf.

[NetanelBasal]

You're welcome to submit a POC