From 4dcd4363f37c480a7746bab98160b84f57591ff3 Mon Sep 17 00:00:00 2001
From: Lam Nguyen <la.nguyen@f5.com>
Date: Wed, 2 Apr 2025 07:55:52 -0700
Subject: [PATCH] Playwright: Refactor to use assertions instead

---
 Makefile                            | 2 +-
 layouts/_default/baseof.html        | 2 +-
 tests/src/visual-regression.spec.js | 6 +++++-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 4c390711..3e27dbdc 100644
--- a/Makefile
+++ b/Makefile
@@ -16,7 +16,7 @@ list help::
 	@echo "<PRE-COMMIT>"
 	@echo "	     setup-pre-commit:		Sets up pre-commit (assuming it is installed)"
 	@echo "<PLAYWRIGHT TESTS>"
-	@echo "		 	 test: 		Runs playwright against the old theme."
+	@echo "		 	tests: 		Runs playwright against the old theme."
 	@echo "     tests-update-screenshots:		Runs playwright against the old theme."
 
 .PHONY: biome-format biome-lint biome-all setup-pre-commit tests build-example-site
diff --git a/layouts/_default/baseof.html b/layouts/_default/baseof.html
index 7e17faa0..54e5c04a 100644
--- a/layouts/_default/baseof.html
+++ b/layouts/_default/baseof.html
@@ -171,7 +171,7 @@
       {{ block "header" . }}{{end}}
     </header>
   
-    <section class="base-layout">
+    <section class="base-layout" data-testid="base-layout">
       <section id="breadcrumb-v1">
         {{ if not .IsHome }}
           {{ if not (in .Params.display_breadcrumb "false" ) }}
diff --git a/tests/src/visual-regression.spec.js b/tests/src/visual-regression.spec.js
index 13bb7b54..754fec26 100644
--- a/tests/src/visual-regression.spec.js
+++ b/tests/src/visual-regression.spec.js
@@ -5,7 +5,11 @@ test.describe('Testing old theme', () => {
     page,
   }) => {
     const currentPlus = 'nginx/installing-nginx-open-source/';
-    await page.goto(`/${currentPlus}`, { waitUntil: 'networkidle' });
+    await page.goto(`/${currentPlus}`);
+    await expect(
+      await page.locator('data-testid=base-layout').count()
+    ).toBeTruthy();
+
     await page.waitForFunction(() => window.scrollY === 0);
     await expect(page).toHaveScreenshot('example-site-screenshot.png', {
       fullPage: true,