Skip to content

Update N1 API docs: add staged config one.json changes #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

vivki
Copy link
Contributor

@vivki vivki commented Jan 21, 2025

Proposed changes

This PR updates the API docs for the Staged Configs epic. Also wraps some incremental changes made recently.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@vivki vivki requested a review from a team as a code owner January 21, 2025 21:37
Copy link

github-actions bot commented Jan 21, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@vivki vivki changed the title add staged config one.json changes Update API docs: add staged config one.json changes Jan 21, 2025
@vivki vivki changed the title Update API docs: add staged config one.json changes Update N1 API docs: add staged config one.json changes Jan 21, 2025
@ADubhlaoich
Copy link
Contributor

@vivki You need to accept the F5 CLA: there's also a merge conflict to resolve!

@mjang
Copy link
Contributor

mjang commented Jan 22, 2025

@vivki You need to accept the F5 CLA: there's also a merge conflict to resolve!

FYI, I've been following the sequence of MRs from the source repo, and have resolved the conflict. @vivki , you do need to follow the instructions in #85 (comment)

@mjang mjang assigned mjang and vivki and unassigned mjang Jan 22, 2025
@vivki
Copy link
Contributor Author

vivki commented Jan 28, 2025

recheck

@vivki
Copy link
Contributor Author

vivki commented Jan 28, 2025

I have hereby read the F5 CLA and agree to its terms.

@vivki
Copy link
Contributor Author

vivki commented Jan 28, 2025

recheck

@vivki
Copy link
Contributor Author

vivki commented Jan 28, 2025

I have hereby read the F5 CLA and agree to its terms

@vivki
Copy link
Contributor Author

vivki commented Jan 28, 2025

recheck

@mjang mjang self-requested a review January 28, 2025 22:20
@mjang mjang merged commit aa2a665 into nginx:main Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants