Skip to content

Commit 3735191

Browse files
authored
cs_instance: unbind args cpu, cpu_speed, memory (#114)
1 parent 65a7726 commit 3735191

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
minor_changes:
2+
- cs_instance - The arguments ``cpu``, ``cpu_speed`` and ``memory`` are no longer required to be set together (https://github.com/ngine-io/ansible-collection-cloudstack/issues/111).

plugins/modules/cs_instance.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -736,18 +736,23 @@ def get_user_data(self):
736736

737737
def get_details(self):
738738
details = self.module.params.get('details')
739+
739740
cpu = self.module.params.get('cpu')
740741
cpu_speed = self.module.params.get('cpu_speed')
741742
memory = self.module.params.get('memory')
742-
if all([cpu, cpu_speed, memory]):
743+
744+
if any([cpu, cpu_speed, memory]):
743745
if details is None:
744746
details = {}
745747

746-
details.update({
747-
'cpuNumber': cpu,
748-
'cpuSpeed': cpu_speed,
749-
'memory': memory,
750-
})
748+
if cpu:
749+
details['cpuNumber'] = cpu
750+
751+
if cpu_speed:
752+
details['cpuSpeed'] = cpu_speed
753+
754+
if memory:
755+
details['memory'] = memory
751756

752757
return details
753758

@@ -1109,14 +1114,9 @@ def main():
11091114
allow_root_disk_shrink=dict(type='bool', default=False),
11101115
))
11111116

1112-
required_together = cs_required_together()
1113-
required_together.extend([
1114-
['cpu', 'cpu_speed', 'memory'],
1115-
])
1116-
11171117
module = AnsibleModule(
11181118
argument_spec=argument_spec,
1119-
required_together=required_together,
1119+
required_together=cs_required_together(),
11201120
required_one_of=(
11211121
['display_name', 'name'],
11221122
),

0 commit comments

Comments
 (0)