From 904ad6fd25c899847594a5446a728d1d04eae6ff Mon Sep 17 00:00:00 2001 From: Christopher Hakkaart Date: Fri, 11 Jul 2025 11:20:28 +1200 Subject: [PATCH 1/2] Language suggestion for aws java sdk v2 guide Signed-off-by: Christopher Hakkaart --- docs/guides/aws-java-sdk-v2.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/guides/aws-java-sdk-v2.md b/docs/guides/aws-java-sdk-v2.md index 3cbebcc113..a42faa0c97 100644 --- a/docs/guides/aws-java-sdk-v2.md +++ b/docs/guides/aws-java-sdk-v2.md @@ -2,13 +2,13 @@ # AWS Java SDK v2 -AWS Java SDK v1 is reaching end of life at the end of 2025. Starting in version `25.06.0-edge`, Nextflow uses AWS Java SDK v2 in the `nf-amazon` plugin. +AWS Java SDK v1 will reach end of life at the end of 2025. Starting with version `25.06.0-edge`, Nextflow uses AWS Java SDK v2 in the `nf-amazon` plugin. -This migration introduced several breaking changes to the `aws.client` config scope, including new options and removed options. This page describes these changes and how they affect your Nextflow configuraiton. +This migration introduces several breaking changes to the `aws.client` config scope, including new and removed options. This page describes these changes and how they affect your Nextflow configuration. ## New HTTP client -The HTTP client used by SDK v2 does not support overriding certain advanced HTTP options. As a result, the following config options are no longer supported: +The HTTP client in SDK v2 does not support overriding certain advanced HTTP options. As a result, the following config options are no longer supported: - `aws.client.protocol` - `aws.client.signerOverride` @@ -18,15 +18,15 @@ The HTTP client used by SDK v2 does not support overriding certain advanced HTTP ## S3 transfer manager -The *S3 transfer manager* is a subsystem of SDK v2 which handles S3 transfers, including S3 uploads and downloads. +The *S3 transfer manager* is a subsystem of SDK v2 that handles S3 uploads and downloads. -The concurrency and throughput of the S3 transfer manager can be configured manually using the `aws.client.maxConcurrency` and `aws.client.maxNativeMemory` config options. Alternatively, the `aws.client.targetThroughputInGbps` config option can be used to set the previous two options automatically based on a target throughput. +You can configure the concurrency and throughput of the S3 transfer manager manually using the `aws.client.maxConcurrency` and `aws.client.maxNativeMemory` configuration options. Alternatively, you can use the `aws.client.targetThroughputInGbps` option to set both values automatically based on a target throughput. -## Multi-part uplaods +## Multi-part uploads -Multi-part uploads are handled by the S3 transfer manager. The `aws.client.minimumPartSize` and `aws.client.multipartThreshold` config options can be used to control when and how multi-part uploads are performed. +The S3 transfer manager handles multi-part uploads. You can use the `aws.client.minimumPartSize` and `aws.client.multipartThreshold` config options to control when and how multi-part uploads are performed. -The following multi-part upload options are no longer supported: +The following multi-part upload config options are no longer supported: - `aws.client.uploadChunkSize` - `aws.client.uploadMaxAttempts` From b6253b30e4009cc134e4a4315fd0f7cc6fcb8e22 Mon Sep 17 00:00:00 2001 From: Ben Sherman Date: Fri, 11 Jul 2025 07:40:50 -0500 Subject: [PATCH 2/2] Update docs/guides/aws-java-sdk-v2.md [ci fast] Signed-off-by: Ben Sherman --- docs/guides/aws-java-sdk-v2.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/guides/aws-java-sdk-v2.md b/docs/guides/aws-java-sdk-v2.md index a42faa0c97..f82d50ffd5 100644 --- a/docs/guides/aws-java-sdk-v2.md +++ b/docs/guides/aws-java-sdk-v2.md @@ -24,7 +24,7 @@ You can configure the concurrency and throughput of the S3 transfer manager manu ## Multi-part uploads -The S3 transfer manager handles multi-part uploads. You can use the `aws.client.minimumPartSize` and `aws.client.multipartThreshold` config options to control when and how multi-part uploads are performed. +Multi-part uploads are handled by the S3 transfer manager. You can use the `aws.client.minimumPartSize` and `aws.client.multipartThreshold` config options to control when and how multi-part uploads are performed. The following multi-part upload config options are no longer supported: