[meta] update to Rust 1.87 (#2353)

Consists of illumos posix_spawn fixes in particular.

Author: sunshowers

cargo-nextest/src/double_spawn.rs

@@ -29,6 +29,9 @@ impl DoubleSpawnOpts {
         let mut command = std::process::Command::new(&self.program);
         // Note: exec only returns an error -- in the success case it never returns.
         let err = command.args(args).exec();
-        Err(ExpectedError::DoubleSpawnExecError { command, err })
+        Err(ExpectedError::DoubleSpawnExecError {
+            command: Box::new(command),
+            err,
+        })
     }
 }

cargo-nextest/src/errors.rs

@@ -259,7 +259,7 @@ pub enum ExpectedError {
     },
     #[error("double-spawn execution error")]
     DoubleSpawnExecError {
-        command: std::process::Command,
+        command: Box<std::process::Command>,
         #[source]
         err: std::io::Error,
     },

integration-tests/src/nextest_cli.rs

@@ -62,7 +62,7 @@ impl CargoNextestCli {
         let output = command.output().wrap_err("failed to get current exe")?;
 
         let output = CargoNextestOutput {
-            command,
+            command: Box::new(command),
             exit_status: output.status,
             stdout: output.stdout,
             stderr: output.stderr,
@@ -120,7 +120,7 @@ impl CargoNextestCli {
         let output = command.output().expect("failed to execute");
 
         let ret = CargoNextestOutput {
-            command,
+            command: Box::new(command),
             exit_status: output.status,
             stdout: output.stdout,
             stderr: output.stderr,
@@ -135,7 +135,7 @@ impl CargoNextestCli {
 }
 
 pub struct CargoNextestOutput {
-    pub command: Command,
+    pub command: Box<Command>,
     pub exit_status: ExitStatus,
     pub stdout: Vec<u8>,
     pub stderr: Vec<u8>,

nextest-runner/src/double_spawn.rs

@@ -149,8 +149,7 @@ mod imp {
         let path = Path::new(PROC_SELF_EXE);
         match path.symlink_metadata() {
             Ok(_) => Ok(path.to_owned()),
-            Err(e) if e.kind() == std::io::ErrorKind::NotFound => Err(std::io::Error::new(
-                std::io::ErrorKind::Other,
+            Err(e) if e.kind() == std::io::ErrorKind::NotFound => Err(std::io::Error::other(
                 "no /proc/self/exe available. Is /proc mounted?",
             )),
             Err(e) => Err(e),

nextest-runner/src/reporter/aggregator/junit.rs

@@ -574,7 +574,7 @@ mod tests {
                     errors: ErrorList::new(
                         "collecting child output",
                         vec![ChildError::Fd(ChildFdError::Wait(Arc::new(
-                            io::Error::new(io::ErrorKind::Other, "huh"),
+                            io::Error::other("huh"),
                         )))],
                     ),
                 },
@@ -608,7 +608,7 @@ mod tests {
                     errors: ErrorList::new(
                         "collecting child output",
                         vec![ChildError::Fd(ChildFdError::ReadStdout(Arc::new(
-                            io::Error::new(io::ErrorKind::Other, "stdout error"),
+                            io::Error::other("stdout error"),
                         )))],
                     ),
                 },
@@ -628,7 +628,7 @@ mod tests {
                 comment: "exec fail + combined + store (exec fail means nothing to store)",
                 status: TestCaseStatus::non_success(NonSuccessKind::Error),
                 output: ChildExecutionOutput::StartError(ChildStartError::Spawn(Arc::new(
-                    io::Error::new(io::ErrorKind::Other, "start error"),
+                    io::Error::other("start error"),
                 ))),
                 store_stdout_stderr: true,
                 message: Some("error spawning child process"),

nextest-runner/src/reporter/structured/libtest.rs

@@ -773,7 +773,7 @@ note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose bac
     #[test]
     fn strips_human_output_start_error() {
         let inner_error = eyre!("inner error");
-        let error = io::Error::new(io::ErrorKind::Other, inner_error);
+        let error = io::Error::other(inner_error);
 
         let output = ChildExecutionOutput::StartError(ChildStartError::Spawn(Arc::new(error)));
 

nextest-runner/src/reuse_build/archiver.rs

@@ -683,8 +683,7 @@ fn find_std(libdir: &Utf8Path) -> io::Result<Utf8PathBuf> {
         }
     }
 
-    Err(io::Error::new(
-        io::ErrorKind::Other,
+    Err(io::Error::other(
         "could not find the Rust standard library in the libdir",
     ))
 }

nextest-runner/src/runner/dispatcher.rs

@@ -836,6 +836,9 @@ impl ContextTestInstance<'_> {
     }
 }
 
+// Almost all events are executor events, which is much larger than the others,
+// so it doesn't make sense to optimize for the rare signal and input events.
+#[expect(clippy::large_enum_variant)]
 #[derive(Debug)]
 enum InternalEvent<'a> {
     Executor(ExecutorEvent<'a>),

nextest-runner/src/update.rs

@@ -449,15 +449,12 @@ impl MuktiUpdateContext<'_> {
             cmd.args(["nextest", "self", "setup", "--source", "self-update"]);
             let status = cmd.status().map_err(UpdateError::SelfSetup)?;
             if !status.success() {
-                return Err(UpdateError::SelfSetup(io::Error::new(
-                    io::ErrorKind::Other,
-                    format!(
-                        "`cargo nextest self setup` failed with exit code {}",
-                        status
-                            .code()
-                            .map_or("(unknown)".to_owned(), |c| c.to_string())
-                    ),
-                )));
+                return Err(UpdateError::SelfSetup(io::Error::other(format!(
+                    "`cargo nextest self setup` failed with exit code {}",
+                    status
+                        .code()
+                        .map_or("(unknown)".to_owned(), |c| c.to_string())
+                ))));
             }
         }
 

nextest-runner/src/write_str.rs

@@ -62,7 +62,7 @@ pub trait WriteStr {
                 if output.error.is_err() {
                     output.error
                 } else {
-                    Err(io::Error::new(io::ErrorKind::Other, "formatter error"))
+                    Err(io::Error::other("formatter error"))
                 }
             }
         }