feat: add param for disabling interchain fees #ntrn-503 #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2025
joldie777
reviewed
Jun 25, 2025
package.json
Outdated
| @@ -52,7 +52,7 @@ | |||
| "@cosmjs/stargate": "0.32.4", | |||
| "@cosmjs/tendermint-rpc": "^0.32.4", | |||
| "@neutron-org/neutronjs": "https://github.com/neutron-org/neutronjs.git#a605a124e5fbae81af768a7910166fa3aa3a31f8", | |||
| "@neutron-org/neutronjsplus": "https://github.com/neutron-org/neutronjsplus.git#caa491bd0e219a6ac1b15505802eefb73b52724e", | |||
| "@neutron-org/neutronjsplus": "https://github.com/neutron-org/neutronjsplus.git#45527108aca64fb3c4433c4927b43310c6dd4aaf", | |||
There was a problem hiding this comment.
It doesn't seem crucial, but shouldn't the latest neutronjsplus commit hash be used here?
joldie777
previously approved these changes
Jun 25, 2025
sotnikov-s
requested changes
Jun 30, 2025
sotnikov-s
reviewed
Jul 2, 2025
sotnikov-s
previously approved these changes
Jul 3, 2025
joldie777
previously approved these changes
Jul 4, 2025
This was referenced Jul 9, 2025
pr0n00gler
reviewed
Jul 9, 2025
pr0n00gler
previously approved these changes
Jul 9, 2025
sotnikov-s
requested changes
Jul 10, 2025
|
resolve conflicts please. the rest LGTM |
NeverHappened
force-pushed
the
feat/disable-feerefunder-fee
branch
from
ee28a63 to
5962ee8
Compare
sotnikov-s
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check ability to disable ibc fees for ibc transfer and interchain transactions.
https://hadronlabs.atlassian.net/browse/NTRN-503
PR's: