Merged main

Signed-off-by: Adam Li <adam2392@gmail.com>

Author: adam2392

sklearn/tree/_splitter.pxd

@@ -110,6 +110,8 @@ cdef class Splitter(BaseSplitter):
     cdef bint check_presplit_conditions(
         self,
         SplitRecord current_split,
+        SIZE_t n_missing,
+        bint missing_go_to_left,
     ) noexcept nogil
     cdef bint check_postsplit_conditions(
         self

sklearn/tree/_splitter.pyx

@@ -505,7 +505,7 @@ cdef inline int node_split_best(
                 current_split.pos = p
 
                 # Reject if min_samples_leaf is not guaranteed
-                if splitter.check_presplit_conditions(current_split) == 1:
+                if splitter.check_presplit_conditions(current_split, n_missing, missing_go_to_left) == 1:
                     continue
 
                 criterion.update(current_split.pos)
@@ -834,7 +834,7 @@ cdef inline int node_split_random(
         current_split.pos = partitioner.partition_samples(current_split.threshold)
 
         # Reject if min_samples_leaf is not guaranteed
-        if splitter.check_presplit_conditions(current_split) == 1:
+        if splitter.check_presplit_conditions(current_split, 0, 0) == 1:
             continue
 
         # Evaluate split

sklearn/tree/_tree.pyx

@@ -764,7 +764,7 @@ cdef class BaseTree:
 
                 # While node not a leaf
                 while node.left_child != _TREE_LEAF:
-                    X_i_node_features = self._compute_feature(X_ndarray, i, node)
+                    X_i_node_feature = self._compute_feature(X_ndarray, i, node)
                     # ... and node.right_child != _TREE_LEAF:
                     if isnan(X_i_node_feature):
                         if node.missing_go_to_left: