Skip to content

Commit eea1eb2

Browse files
authored
Fix nightly issues with python 3.11 (#371)
* allow using run_id * clean up * show disk space * use ubuntu-24.04
1 parent 38cbdd1 commit eea1eb2

File tree

3 files changed

+37
-17
lines changed

3 files changed

+37
-17
lines changed

.github/actions/test/action.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,13 @@ runs:
2222
name: compressed
2323
extra: "[dev,accelerate]"
2424

25+
- name: clean up
26+
run: |
27+
echo "cleaning up wheel files..."
28+
find . -type f -name '*.whl' -exec rm -rf {} \;
29+
df -h
30+
shell: bash
31+
2532
- name: test
2633
id: test
2734
run: |

.github/workflows/test.yml

Lines changed: 29 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ on:
2222
whl:
2323
description: "whl to test (variable appears late binding so unusable outside 'download artifact')"
2424
type: string
25-
required: true
25+
run_id:
26+
description: run id of the BUILD job that generated the assets
27+
type: string
2628

2729
# makes workflow manually callable
2830
workflow_dispatch:
@@ -44,9 +46,11 @@ on:
4446
type: string
4547
required: true
4648
whl:
47-
description: "whl to test (variable appears late binding so unusable outside 'download artifact')"
49+
description: "whl to test (provide either whl or run_id)"
50+
type: string
51+
run_id:
52+
description: run id of the BUILD job that generated the assets
4853
type: string
49-
required: true
5054

5155
jobs:
5256

@@ -87,11 +91,33 @@ jobs:
8791

8892
- name: download whl
8993
id: download
94+
if: ${{ inputs.whl != '' }}
9095
uses: actions/download-artifact@v4
9196
with:
9297
name: ${{ inputs.whl }}
9398
path: ${{ inputs.whl }}
9499

100+
# GCP
101+
- name: 'Authenticate to Google Cloud'
102+
id: auth
103+
uses: google-github-actions/auth@v2.1.3
104+
with:
105+
project_id: ${{ secrets.GCP_PROJECT }}
106+
workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}
107+
service_account: ${{ secrets.GCP_GHA_SA }}
108+
109+
- name: 'Set up Cloud SDK'
110+
uses: 'google-github-actions/setup-gcloud@v2'
111+
with:
112+
version: '>= 473.0.0'
113+
114+
- name: download assets
115+
if: ${{ inputs.run_id != '' }}
116+
uses: neuralmagic/nm-actions/actions/gcp-download-assets@v1.1.0
117+
with:
118+
bucket_source: ${{ secrets.GCP_BUILD_ML_ASSETS2 }}
119+
run_id: ${{ inputs.run_id }}
120+
95121
- name: run tests
96122
id: test
97123
uses: ./.github/actions/test/
@@ -109,19 +135,6 @@ jobs:
109135
whl: ${{ inputs.whl }}
110136
test_status: ${{ steps.test.outputs.status }}
111137

112-
# GCP
113-
- name: 'Authenticate to Google Cloud'
114-
id: auth
115-
uses: google-github-actions/auth@v2.1.3
116-
with:
117-
project_id: ${{ secrets.GCP_PROJECT }}
118-
workload_identity_provider: ${{ secrets.GCP_WORKLOAD_IDENTITY_PROVIDER }}
119-
service_account: ${{ secrets.GCP_GHA_SA }}
120-
121-
- name: 'Set up Cloud SDK'
122-
uses: 'google-github-actions/setup-gcloud@v2'
123-
with:
124-
version: '>= 473.0.0'
125138

126139
- name: copy results to GCP
127140
run: |

.github/workflows/trigger-all.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
wf_category: ${{ inputs.wf_category || 'NIGHTLY' }}
3333
gitref: ${{ inputs.gitref || 'main' }}
3434
push_to_pypi: ${{ (github.event.schedule == '30 0 * * *') || inputs.push_to_pypi || false }}
35-
test_configs: '[{"python":"3.11.4","label":"ubuntu-22.04","timeout":"40"},
35+
test_configs: '[{"python":"3.11.4","label":"ubuntu-24.04","timeout":"40"},
3636
{"python":"3.10.12","label":"ubuntu-24.04","timeout":"40"},
3737
{"python":"3.9.17","label":"k8s-h100-solo","timeout":"40"},
3838
{"python":"3.12.6","label":"k8s-a100-duo","timeout":"40"}]'

0 commit comments

Comments
 (0)