Skip to content

Commit f730b15

Browse files
committed
tighten up the exchange code
1 parent e7e1d5d commit f730b15

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

api/v1/auth/auth.go

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,14 @@ func oauth2Exchange(c *gin.Context) {
135135
"loginVals": loginVals,
136136
}).Info("loginVals")
137137

138+
exists := false
139+
var savedState interface{}
140+
138141
cacheDb := c.MustGet("cache").(*cache.Cache)
139-
savedState, exists := cacheDb.Get(loginVals.ClientId)
142+
143+
if loginVals.ClientId != "" {
144+
savedState, exists = cacheDb.Get(loginVals.ClientId)
145+
}
140146

141147
if !exists {
142148
savedState, exists = cacheDb.Get(loginVals.State)
@@ -201,8 +207,14 @@ func token(c *gin.Context) {
201207
"loginVals": loginVals,
202208
}).Info("loginVals")
203209

210+
exists := false
211+
var savedState interface{}
212+
204213
cacheDb := c.MustGet("cache").(*cache.Cache)
205-
savedState, exists := cacheDb.Get(loginVals.Code)
214+
215+
if loginVals.ClientId != "" {
216+
savedState, exists = cacheDb.Get(loginVals.Code)
217+
}
206218

207219
if !exists {
208220
savedState, exists = cacheDb.Get(loginVals.State)

0 commit comments

Comments
 (0)