Fix bug in transaction listing for admins (#187)

mraerino · web-flow · commit ac25dbde8577 · 2019-09-10T18:13:23.000+02:00
diff --git a/api/payments.go b/api/payments.go
@@ -513,8 +513,13 @@ func queryForOrder(db *gorm.DB, orderID string, log logrus.FieldLogger) (*models
 }
 
 func queryForTransactions(db *gorm.DB, log logrus.FieldLogger, clause, id string) ([]models.Transaction, *HTTPError) {
+	params := []interface{}{}
+	if clause != "" {
+		params = []interface{}{clause, id}
+	}
+
 	trans := []models.Transaction{}
-	if rsp := db.Find(&trans, clause, id); rsp.Error != nil {
+	if rsp := db.Find(&trans, params...); rsp.Error != nil {
 		if rsp.RecordNotFound() {
 			return nil, notFoundError("Transactions not found")
 		}

Original file line number	Diff line number	Diff line change
`@@ -513,8 +513,13 @@ func queryForOrder(db gorm.DB, orderID string, log logrus.FieldLogger) (models`
`513`	`513`	`}`
`514`	`514`
`515`	`515`	`func queryForTransactions(db gorm.DB, log logrus.FieldLogger, clause, id string) ([]models.Transaction, HTTPError) {`
	`516`	`+ params := []interface{}{}`
	`517`	`+ if clause != "" {`
	`518`	`+ params = []interface{}{clause, id}`
	`519`	`+ }`
	`520`	`+`
`516`	`521`	`trans := []models.Transaction{}`
`517`		`- if rsp := db.Find(&trans, clause, id); rsp.Error != nil {`
	`522`	`+ if rsp := db.Find(&trans, params...); rsp.Error != nil {`
`518`	`523`	`if rsp.RecordNotFound() {`
`519`	`524`	`return nil, notFoundError("Transactions not found")`
`520`	`525`	`}`