fix: use correct parameters in callback syntax (#4)

* fix: use correct parameters in callback syntax

* chore: fix eslint paths

Author: eduardoboucas

package.json

@@ -25,7 +25,7 @@
     "test:ci:ava": "nyc -r lcovonly -r text -r json ava"
   },
   "config": {
-    "eslint": "--ignore-pattern 'README.md' --ignore-path .gitignore --cache --format=codeframe --max-warnings=0 \"{src,scripts,.github}/**/*.{js,md,html}\" \"*.{js,md,html}\" \".*.{js,md,html}\"",
+    "eslint": "--ignore-pattern README.md --ignore-path .gitignore --cache --format=codeframe --max-warnings=0 \"{src,scripts,.github}/**/*.{js,md,html}\" \"*.{js,md,html}\" \".*.{js,md,html}\"",
     "prettier": "--ignore-path .gitignore --loglevel=warn \"{src,scripts,.github}/**/*.{js,md,yml,json,html}\" \"*.{js,yml,json,html}\" \".*.{js,yml,json,html}\" \"!**/package-lock.json\" \"!package-lock.json\""
   },
   "ava": {

src/lib/builder_functions.js

@@ -21,7 +21,7 @@ const wrapHandler = (handler) => async (event, context, callback) => {
   }
 
   // eslint-disable-next-line promise/prefer-await-to-callbacks
-  const wrappedCallback = (response) => callback(augmentResponse(response))
+  const wrappedCallback = (error, response) => callback(error, augmentResponse(response))
   const response = await handler(event, context, wrappedCallback)
 
   return augmentResponse(response)

test/builder_functions.js

@@ -31,7 +31,7 @@ test('Injects the metadata object into a synchronous handler', async (t) => {
     statusCode: 200,
   }
   const myHandler = (event, context, callback) => {
-    callback(originalResponse)
+    callback(null, originalResponse)
   }
   const response = await invokeLambda(builderFunction(myHandler))
 

test/helpers/main.js

@@ -3,8 +3,16 @@ const invokeLambda = (handler, { method = 'GET' } = {}) => {
     httpMethod: method,
   }
 
-  return new Promise((resolve) => {
-    resolve(handler(event, {}, resolve))
+  return new Promise((resolve, reject) => {
+    const callback = (error, response) => {
+      if (error) {
+        reject(error)
+      } else {
+        resolve(response)
+      }
+    }
+
+    resolve(handler(event, {}, callback))
   })
 }