Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Commit 2c9edc6

Browse files
authored
fix(handler type): make callback parameter optional (#222)
1 parent 21cc29f commit 2c9edc6

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/function/handler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export interface HandlerCallback<ResponseType extends Response = Response> {
88
}
99

1010
export interface BaseHandler<ResponseType extends Response = Response, C extends Context = Context> {
11-
(event: Event, context: C, callback: HandlerCallback<ResponseType>): void | ResponseType | Promise<ResponseType>
11+
(event: Event, context: C, callback?: HandlerCallback<ResponseType>): void | ResponseType | Promise<ResponseType>
1212
}
1313

1414
export type Handler = BaseHandler<Response, Context>

src/lib/builder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const augmentResponse = (response: BuilderResponse) => {
2121
const wrapHandler =
2222
(handler: BuilderHandler): Handler =>
2323
// eslint-disable-next-line promise/prefer-await-to-callbacks
24-
(event: HandlerEvent, context: HandlerContext, callback: HandlerCallback<Response>) => {
24+
(event: HandlerEvent, context: HandlerContext, callback?: HandlerCallback<Response>) => {
2525
if (event.httpMethod !== 'GET' && event.httpMethod !== 'HEAD') {
2626
return Promise.resolve({
2727
body: 'Method Not Allowed',
@@ -37,7 +37,7 @@ const wrapHandler =
3737
}
3838

3939
// eslint-disable-next-line promise/prefer-await-to-callbacks
40-
const wrappedCallback = (error: unknown, response: BuilderResponse) => callback(error, augmentResponse(response))
40+
const wrappedCallback = (error: unknown, response: BuilderResponse) => callback?.(error, augmentResponse(response))
4141
const execution = handler(modifiedEvent, context, wrappedCallback)
4242

4343
if (isPromise(execution)) {

0 commit comments

Comments
 (0)