Skip to content

Commit 30cd508

Browse files
authored
fix: update edge_bundler_deno_v2 default value (#6753)
1 parent eae1c7c commit 30cd508

File tree

5 files changed

+9
-11
lines changed

5 files changed

+9
-11
lines changed

.github/workflows/workflow.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,12 @@ jobs:
5454
os: [ubuntu-24.04, macos-14, windows-2025]
5555
node-version: ['22']
5656
# Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`.
57-
# We're adding v2.4.2 here because it's needed for the upcoming nimble release, so we can test
58-
# those workflows ahead of time before we can update the base version across the board.
59-
deno-version: ['v1.39.0', 'v2.2.4', 'v2.4.2']
57+
deno-version: ['v2.4.2']
6058
include:
6159
- os: ubuntu-24.04
6260
# Earliest supported version
6361
node-version: '18.14.0'
64-
deno-version: 'v2.2.4'
62+
deno-version: 'v2.4.2'
6563
fail-fast: false
6664
steps:
6765
# Sets an output parameter if this is a release PR
@@ -159,7 +157,7 @@ jobs:
159157
- name: Setup Deno
160158
uses: denoland/setup-deno@v1
161159
with:
162-
deno-version: v2.2.4
160+
deno-version: v2.4.2
163161
if: ${{ !steps.release-check.outputs.IS_RELEASE }}
164162
- name: Node.js ${{ matrix.node-version }}
165163
uses: actions/setup-node@v6

packages/build/tests/edge_functions/snapshots/tests.js.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1279,7 +1279,7 @@ Generated by [AVA](https://avajs.dev).
12791279
────────────────────────────────────────────────────────────────␊
12801280
12811281
Error message␊
1282-
Error: Command failed with exit code 1: "/external/path" bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts␊
1282+
Error: Command failed with exit code 1: deno bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts␊
12831283
STACK TRACE␊
12841284
12851285
export async () => ␊
@@ -1292,9 +1292,9 @@ Generated by [AVA](https://avajs.dev).
12921292
12931293
Error properties␊
12941294
{␊
1295-
shortMessage: 'Command failed with exit code 1: "/external/path" bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊
1296-
command: '"/external/path" bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊
1297-
escapedCommand: '"/external/path" bundle --import-map "BASE64_STRING" --quiet --code-splitting --allow-import --outdir "/external/path" "packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts"',␊
1295+
shortMessage: 'Command failed with exit code 1: deno bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊
1296+
command: 'deno bundle --import-map BASE64_STRING --quiet --code-splitting --allow-import --outdir /external/path packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts',␊
1297+
escapedCommand: 'deno bundle --import-map "BASE64_STRING" --quiet --code-splitting --allow-import --outdir "/external/path" "packages/build/tests/edge_functions/fixtures/functions_invalid/netlify/edge-functions/functions-1.ts"',␊
12981298
exitCode: 1,␊
12991299
signal: undefined,␊
13001300
signalDescription: undefined,␊
1 Byte
Binary file not shown.

packages/build/tests/edge_functions/tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ for (const variant of FLAG_VARIANTS) {
174174
t.snapshot(normalizeOutput(output))
175175
})
176176

177-
test(variant.id + ' - bundles Edge Functions via runCoreSteps function', async (t) => {
177+
test.serial(variant.id + ' - bundles Edge Functions via runCoreSteps function', async (t) => {
178178
const output = await new Fixture('./fixtures/functions_user')
179179
.withFlags({ ...variant.flags, buildSteps: ['edge_functions_bundling'], useRunCoreSteps: true })
180180
.runWithBuild()

packages/edge-bundler/node/feature_flags.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const defaultFlags = {
22
edge_bundler_generate_tarball: false,
33
edge_bundler_dry_run_generate_tarball: false,
4-
edge_bundler_deno_v2: false,
4+
edge_bundler_deno_v2: true,
55
}
66

77
type FeatureFlag = keyof typeof defaultFlags

0 commit comments

Comments
 (0)