fix: ensure that go is always correctly installed (#887)

* fix: ensure that go is always correctly installed

* adapt tests

* more tests and do not allow installs from git

Author: danez

Dockerfile

@@ -468,6 +468,8 @@ ENV GOCACHE "/opt/buildhome/.gimme_cache/gocache"
 # Install the default version
 ENV GIMME_GO_VERSION "1.19.x"
 ENV GIMME_ENV_PREFIX "/opt/buildhome/.gimme/env"
+ENV GIMME_VERSION_PREFIX "/opt/buildhome/.gimme/versions"
+ENV GIMME_TYPE "binary"
 RUN gimme | bash
 
 ################################################################################

run-build-functions.sh

@@ -1015,28 +1015,27 @@ install_go() {
     fi
   fi
 
-  if [ "$GIMME_GO_VERSION" != "$installGoVersion" ]
+  # Cache known version for 7days (604800 seconds)
+  resolvedGoVersion="$(GIMME_KNOWN_CACHE_MAX=604800 gimme --resolve $installGoVersion)"
+  if [ $? -ne 0 ]
+  then
+    echo "Failed to resolve Go version '$installGoVersion'"
+    exit 1
+  fi
+
+  gimmeEnvFile=$HOME/.gimme/env/go$resolvedGoVersion.linux.$(dpkg --print-architecture).env
+
+  # Check if the version is already installed by gimme
+  if [ ! -f $gimmeEnvFile ]
   then
-    resolvedGoVersion=$(gimme --resolve $installGoVersion)
     echo "Installing Go version $resolvedGoVersion (requested $installGoVersion)"
     GIMME_ENV_PREFIX=$HOME/.gimme/env GIMME_VERSION_PREFIX=$HOME/.gimme/versions gimme $resolvedGoVersion
-    if [ $? -eq 0 ]
+    if [ $? -ne 0 ]
     then
-      source $HOME/.gimme/env/go$resolvedGoVersion.linux.$(dpkg --print-architecture).env
-    else
       echo "Failed to install Go version '$resolvedGoVersion'"
       exit 1
     fi
-  else
-    gimme | bash
-    if [ $? -eq 0 ]
-    then
-      source $HOME/.gimme/env/go$GIMME_GO_VERSION.linux.amd64.env
-    else
-      echo "Failed to install Go version '$GIMME_GO_VERSION'"
-      exit 1
-    fi
   fi
 
+  source $gimmeEnvFile
 }
-

tests/go/base.bats

@@ -15,10 +15,28 @@ setup() {
   run install_go
   assert_success
   # we can't specify which patch version because it will change
-  assert_output --partial "Installing Go version 1.19."
+  # Also no message about installation will be shown because it is the default already installed version
+  refute_output --partial "Installing Go version 1.19."
   assert_output --partial "go version go1.19."
 }
 
+@test 'go version 1.19 at the latest patch is installed and available at startup by default when specifying default version' {
+  run install_go $GIMME_GO_VERSION
+  assert_success
+  # we can't specify which patch version because it will change
+  # Also no message about installation will be shown because it is the default already installed version
+  refute_output --partial "Installing Go version 1.19."
+  assert_output --partial "go version go1.19."
+}
+
+@test 'an unresolvable go version fails script' {
+  run install_go "notaversion"
+  assert_failure
+  assert_output --partial "Failed to resolve Go version 'notaversion'"
+  refute_output --partial "Installing Go version"
+  refute_output --partial "go version go"
+}
+
 @test 'install custom go version' {
   local customGoVersion=1.16.4
   run install_go $customGoVersion