[NAE-1690] Fix header responsive overflow mode

- sort constructor

Author: machacjozef

projects/netgrif-components-core/src/lib/panel/abstract/panel-with-header-binding.ts

@@ -1,7 +1,8 @@
-import {Component, OnDestroy, OnInit} from '@angular/core';
+import {Component, OnDestroy, OnInit, Optional} from '@angular/core';
 import {Observable, Subscription} from 'rxjs';
 import {HeaderColumn, HeaderColumnType} from '../../header/models/header-column';
 import {FeaturedValue} from './featured-value';
+import {OverflowService} from '../../header/services/overflow.service';
 
 @Component({
     selector: 'ncc-abstract-panel-with-header-binding',
@@ -14,7 +15,15 @@ export abstract class AbstractPanelWithHeaderBindingComponent implements OnInit,
     protected _lastSelectedHeaders: Array<HeaderColumn>;
     protected sub: Subscription;
 
-    protected constructor() {
+    protected constructor(@Optional() protected _overflowService: OverflowService) {
+    }
+
+    get overflowMode(): boolean {
+        if(!!this._overflowService){
+            return this._overflowService.overflowMode;
+        } else {
+            return false;
+        }
     }
 
     ngOnInit(): void {

projects/netgrif-components-core/src/lib/panel/abstract/panel-with-immediate-data.ts

@@ -16,15 +16,7 @@ export abstract class AbstractPanelWithImmediateDataComponent extends AbstractPa
     protected constructor(protected _translate: TranslateService,
                           protected _currencyPipe: CurrencyPipe,
                           @Optional() protected _overflowService: OverflowService) {
-        super();
-    }
-
-    get overflowMode(): boolean {
-        if(!!this._overflowService){
-        return this._overflowService.overflowMode;
-        } else {
-            return false;
-        }
+        super(_overflowService);
     }
 
     ngOnDestroy(): void {

projects/netgrif-components-core/src/lib/panel/case-panel/abstract-case-panel.component.spec.ts

@@ -63,7 +63,11 @@ describe('AbstractCasePanelComponent', () => {
                 {provide: AuthenticationMethodService, useClass: MockAuthenticationMethodService},
                 {provide: AuthenticationService, useClass: MockAuthenticationService},
                 SignUpService,
-                {provide: AllowedNetsService, useFactory: TestCaseViewAllowedNetsFactory, deps: [AllowedNetsServiceFactory]}
+                {
+                    provide: AllowedNetsService,
+                    useFactory: TestCaseViewAllowedNetsFactory,
+                    deps: [AllowedNetsServiceFactory]
+                }
             ],
             declarations: [
                 TestCasePanelComponent,
@@ -101,13 +105,17 @@ describe('AbstractCasePanelComponent', () => {
     template: ''
 })
 class TestCasePanelComponent extends AbstractCasePanelComponent {
-    constructor(protected _caseResourceService: CaseResourceService, protected _caseViewService: CaseViewService,
-                protected _snackBarService: SnackBarService, protected _translateService: TranslateService,
-                protected _log: LoggerService, @Optional() protected overflowService: OverflowService,
-                protected _userService: UserService, protected _currencyPipe: CurrencyPipe,
-                protected _permissionService: PermissionService) {
-        super(_caseResourceService, _caseViewService, _snackBarService, _translateService, _log, overflowService,
-            _userService, _currencyPipe, _permissionService);
+    constructor(protected _caseResourceService: CaseResourceService,
+                protected _caseViewService: CaseViewService,
+                protected _snackBarService: SnackBarService,
+                protected _translateService: TranslateService,
+                protected _log: LoggerService,
+                protected _userService: UserService,
+                protected _currencyPipe: CurrencyPipe,
+                protected _permissionService: PermissionService,
+                @Optional() protected overflowService: OverflowService) {
+        super(_caseResourceService, _caseViewService, _snackBarService, _translateService, _log,
+            _userService, _currencyPipe, _permissionService, overflowService,);
     }
 }
 
@@ -116,7 +124,7 @@ class TestCasePanelComponent extends AbstractCasePanelComponent {
     template: '<ncc-test-case-panel [selectedHeaders$]="selectedHeaders" [case_]="case_"> </ncc-test-case-panel>'
 })
 class TestWrapperComponent {
-    selectedHeaders =  of([
+    selectedHeaders = of([
         new HeaderColumn(HeaderColumnType.META, CaseMetaField.VISUAL_ID, 'string', 'string'),
         new HeaderColumn(HeaderColumnType.META, CaseMetaField.AUTHOR, 'string', 'string'),
         new HeaderColumn(HeaderColumnType.META, CaseMetaField.TITLE, 'string', 'string'),
@@ -155,7 +163,7 @@ class TestWrapperComponent {
             {stringId: 'date', title: 'string', type: 'date', value: [2020, 1, 1, 10, 10]},
             {stringId: 'string', title: 'string', type: 'string', value: 'dasdsadsad'},
             {stringId: 'dateTime', title: 'string', type: 'dateTime', value: [2020, 1, 1, 10, 10]},
-            {stringId: 'enum', title: 'string', type: 'enumeration', value: { defaultValue: 'dasd'}},
+            {stringId: 'enum', title: 'string', type: 'enumeration', value: {defaultValue: 'dasd'}},
         ]
     };
 }

projects/netgrif-components-core/src/lib/panel/case-panel/abstract-case-panel.component.ts

@@ -41,10 +41,10 @@ export abstract class AbstractCasePanelComponent extends AbstractPanelWithImmedi
                           protected _snackBarService: SnackBarService,
                           protected _translateService: TranslateService,
                           protected _log: LoggerService,
-                          @Optional() protected _overflowService: OverflowService,
                           protected _userService: UserService,
                           protected _currencyPipe: CurrencyPipe,
-                          protected _permissionService: PermissionService) {
+                          protected _permissionService: PermissionService,
+                          @Optional() protected _overflowService: OverflowService,) {
         super(_translateService, _currencyPipe, _overflowService);
     }
 

projects/netgrif-components-core/src/lib/panel/workflow-panel/abstract-workflow-panel.component.ts

@@ -50,7 +50,7 @@ export abstract class AbstractWorkflowPanelComponent extends AbstractPanelWithHe
                           protected _translate: TranslateService,
                           protected _workflowService: WorkflowViewService,
                           @Optional() protected _overflowService: OverflowService) {
-        super();
+        super(_overflowService);
 
         this._subscription = _translate.onLangChange.subscribe((event: TranslationChangeEvent) => {
             this.panelContent.netIdentifier.title = this._translate.instant(this.TRANSLATION_NET);
@@ -83,14 +83,6 @@ export abstract class AbstractWorkflowPanelComponent extends AbstractPanelWithHe
         this.panelRef = panelRef;
     }
 
-    get overflowMode(): boolean {
-        if(this._overflowService !== null){
-            return this._overflowService.overflowMode;
-        } else {
-            return false;
-        }
-    }
-
     /**
      * Handles the logic that should be executed when the "delete workflow" button is clicked.
      *

projects/netgrif-components/src/lib/panel/case-panel/case-panel.component.ts

@@ -1,5 +1,11 @@
 import {Component, Optional} from '@angular/core';
-import {AbstractCasePanelComponent, CaseViewService, LoggerService, OverflowService, UserService} from '@netgrif/components-core';
+import {
+    AbstractCasePanelComponent,
+    CaseViewService,
+    LoggerService,
+    OverflowService,
+    UserService
+} from '@netgrif/components-core';
 import {CaseResourceService, PermissionService} from '@netgrif/components-core';
 import {SnackBarService} from '@netgrif/components-core';
 import {TranslateService} from '@ngx-translate/core';
@@ -11,12 +17,16 @@ import {CurrencyPipe} from '@angular/common';
     styleUrls: ['./case-panel.component.scss']
 })
 export class CasePanelComponent extends AbstractCasePanelComponent {
-    constructor(protected _caseResourceService: CaseResourceService, protected _caseViewService: CaseViewService,
-                protected _snackBarService: SnackBarService, protected _translateService: TranslateService,
-                protected _log: LoggerService, @Optional() protected _overflowService: OverflowService,
-                protected _userService: UserService, protected _currencyPipe: CurrencyPipe,
-                public _permissionService: PermissionService) {
+    constructor(protected _caseResourceService: CaseResourceService,
+                protected _caseViewService: CaseViewService,
+                protected _snackBarService: SnackBarService,
+                protected _translateService: TranslateService,
+                protected _log: LoggerService,
+                protected _userService: UserService,
+                protected _currencyPipe: CurrencyPipe,
+                public _permissionService: PermissionService,
+                @Optional() protected _overflowService: OverflowService) {
         super(_caseResourceService, _caseViewService, _snackBarService,
-            _translateService, _log, _overflowService, _userService, _currencyPipe, _permissionService);
+            _translateService, _log, _userService, _currencyPipe, _permissionService, _overflowService);
     }
 }