Merge pull request #10 from netglade/release-2.0.0

Release 2.0.0

Author: tenhobi

.github/workflows/ci.yaml

@@ -31,7 +31,7 @@ jobs:
           sudo apt-get install dcm
 
       - name: DCM Analyze
-        run: dcm analyze --reporter=github --ci-key ${{ secrets.DCM_KEY }} --email ${{ secrets.DCM_EMAIL }} .
+        run: dcm analyze --reporter=github --ci-key ${{ secrets.DCM_KEY }} --email ${{ secrets.DCM_EMAIL }} --fatal-style --fatal-performance --fatal-warnings .
 
       - name: Dry Publish
         run: dart pub publish --dry-run

CHANGELOG.md

@@ -1,5 +1,102 @@
-## 2.0.0-rc.1
-- Update DCM rules to adhere DCM Teams 1.6.0.
+## 2.0.0
+- New Dart lints:
+  - collection_methods_unrelated_type
+  - deprecated_member_use_from_same_package
+  - implicit_reopen
+  - invalid_case_patterns
+  - unnecessary_library_directive
+  - combinators_ordering
+  - dangling_library_doc_comments
+  - implicit_call_tearoffs
+  - matching_super_parameters
+  - no_literal_bool_comparisons
+  - type_literal_in_constant_pattern
+  - unnecessary_breaks
+  - use_string_in_part_of_directives
+- Update DCM rules and CI to adhere DCM Teams 1.6.0.
+- New DCM lints:
+  - avoid-any-version
+  - banned-dependencies
+  - prefer-caret-version-syntax
+  - prefer-correct-screenshots
+  - prefer-publish-to-none
+  - prefer-semver-version
+  - avoid-bottom-type-in-patterns
+  - avoid-bottom-type-in-records
+  - avoid-collapsible-if
+  - avoid-declaring-call-method
+  - avoid-duplicate-named-imports
+  - avoid-duplicate-patterns
+  - avoid-equal-expressions
+  - avoid-explicit-pattern-field-name
+  - avoid-function-type-in-records
+  - avoid-future-tostring
+  - avoid-inverted-boolean-checks
+  - avoid-long-records
+  - avoid-missed-calls
+  - avoid-mixing-named-and-positional-fields
+  - avoid-nested-records
+  - avoid-nested-switch-expressions
+  - avoid-nested-switches
+  - avoid-one-field-records
+  - avoid-positional-record-field-access
+  - avoid-redundant-else
+  - avoid-redundant-positional-field-name
+  - avoid-redundant-pragma-inline
+  - avoid-self-assignment
+  - avoid-self-compare
+  - avoid-shadowing
+  - avoid-substring
+  - avoid-throw-objects-without-tostring
+  - avoid-unassigned-late-fields-keyword
+  - avoid-unnecessary-conditionals
+  - avoid-unnecessary-negations
+  - avoid-unnecessary-nullable-return-type
+  - avoid-unnecessary-return
+  - avoid-unrelated-type-casts
+  - avoid-unsafe-collection-methods
+  - avoid-unused-generics
+  - function-always-returns-null
+  - move-records-to-typedefs
+  - no-equal-conditions
+  - no-equal-switch-case
+  - no-equal-switch-expression-cases
+  - prefer-bytes-builder
+  - prefer-correct-switch-length
+  - prefer-declaring-const-constructor
+  - prefer-early-return
+  - prefer-explicit-parameter-names
+  - prefer-return-await
+  - prefer-simpler-patterns-null-check
+  - prefer-test-matchers
+  - prefer-visible-for-testing-on-members
+  - prefer-wildcard-pattern
+  - unnecessary-trailing-comma
+  - add-copy-with
+  - avoid-empty-setstate
+  - avoid-expanded-as-spacer
+  - avoid-incomplete-copy-with
+  - avoid-inherited-widget-in-initstate
+  - avoid-late-context
+  - avoid-state-constructors
+  - avoid-stateless-widget-initialized-fields
+  - avoid-unnecessary-stateful-widgets
+  - dispose-fields
+  - prefer-action-button-tooltip
+  - prefer-define-hero-tag
+  - proper-super-calls
+  - use-setstate-synchronously
+  - avoid-instantiating-in-value-provider
+  - avoid-read-inside-build
+  - avoid-watch-outside-build
+  - dispose-providers
+  - prefer-multi-provider
+  - avoid-bloc-public-methods
+  - check-is-not-closed-after-async-gap
+  - prefer-correct-bloc-provider
+  - prefer-multi-bloc-provider
+  - extend-equatable
+  - list-all-equatable-fields
 
 ## 1.2.3
 - Fix pub dev icon.

README.md

@@ -1,9 +1,5 @@
 <a href="https://github.com/netglade">
-  <picture >
-    <source media="(prefers-color-scheme: dark)" height='120px' srcset="https://raw.githubusercontent.com/netglade/netglade_analysis/main/doc/badge_light.png">
-    <source media="(prefers-color-scheme: light)" height='120px' srcset="https://raw.githubusercontent.com/netglade/netglade_analysis/main/doc/badge_dark.png">
     <img alt="netglade" height='120px' src="https://raw.githubusercontent.com/netglade/netglade_analysis/main/doc/badge_dark.png">
-  </picture>
 </a>
 
 Developed with 💚 by [netglade][netglade_link]

lib/dcm.yaml

@@ -1,4 +1,4 @@
-# version 1.6.0
+# version 1.6.0 - https://dcm.dev/changelog/
 dart_code_metrics:
   pubspec-rules:
     ### Pubspec
@@ -38,7 +38,8 @@ dart_code_metrics:
     - avoid-inverted-boolean-checks
     # - avoid-late-keyword
     # - avoid-long-functions # way too pedantic
-    # - avoid-long-parameter-list # doesn't play well with Flutter
+    - avoid-long-parameter-list:
+        ignore-optional: true # exclude optional and (required) named parameters
     - avoid-long-records
     - avoid-missed-calls
     - avoid-missing-enum-constant-in-map
@@ -163,7 +164,7 @@ dart_code_metrics:
     - prefer-moving-to-variable:
         allowed-duplicated-chains: 3
     - prefer-return-await
-    - prefer-returning-conditional-expressions
+    # - prefer-returning-conditional-expressions # annoying sometimes
     - prefer-simpler-patterns-null-check
     - prefer-static-class:
         ignore-private: true

lib/lints.yaml

@@ -16,7 +16,7 @@ analyzer:
     deprecated_member_use_from_same_package: warning
     record_literal_one_positional_no_trailing_comma: error
 
-# version 1.3.5 - https://github.com/dart-lang/linter/blob/main/CHANGELOG.md
+# version 1.35.0 - https://github.com/dart-lang/linter/blob/main/CHANGELOG.md
 linter:
   rules:
     ### ERROR

pubspec.yaml

@@ -1,5 +1,5 @@
 name: netglade_analysis
-version: 2.0.0-rc.1
+version: 2.0.0
 description: Lint rules for Dart and Flutter used internally at netglade.
 repository: https://github.com/netglade/netglade_analysis
 issue_tracker: https://github.com/netglade/netglade_analysis/issues