Skip to content

Commit ccc38e6

Browse files
authored
Merge pull request #42 from netglade/feat/adhere-dcm-17
2 parents ffb925d + 60aa1ac commit ccc38e6

File tree

5 files changed

+28
-4
lines changed

5 files changed

+28
-4
lines changed

.github/workflows/netglade_flutter_utils-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525

2626
steps:
2727
- uses: actions/checkout@v4
28-
- uses: subosito/flutter-action@v2.12.0
28+
- uses: subosito/flutter-action@v2.16.0
2929

3030
- name: Install Dependencies
3131
run: flutter pub get

packages/netglade_analysis/CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
## 11.0.0
2+
- Adhere to DCM 1.17.0:
3+
- Add avoid-collection-equality-checks
4+
- Add avoid-multi-assignment
5+
- Add prefer-switch-with-sealed-classes
6+
- Add prefer-single-declaration-per-file
7+
- Add prefer-use-callback
8+
- Add avoid-misused-hooks
9+
- Add avoid-ref-read-inside-build
10+
- Add avoid-ref-watch-outside-build
11+
- Add avoid-unnecessary-consumer-widgets
12+
113
## 10.0.0
214
- Adhere to DCM 1.16.0:
315
- Add avoid-conditions-with-boolean-literals

packages/netglade_analysis/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ To use the lints, add as a dev dependency in your `pubspec.yaml`:
2323

2424
```yaml
2525
dev_dependencies:
26-
netglade_analysis: ^9.0.0
26+
netglade_analysis: ^11.0.0
2727
```
2828
2929
Then, add an include in `analysis_options.yaml`:

packages/netglade_analysis/lib/dcm.yaml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# version 1.16.0 - https://dcm.dev/changelog
1+
# version 1.17.0 - https://dcm.dev/changelog
22
dart_code_metrics:
33
rules:
44
### Common
@@ -16,6 +16,7 @@ dart_code_metrics:
1616
- avoid-cascade-after-if-null
1717
- avoid-casting-to-extension-type
1818
- avoid-collapsible-if
19+
- avoid-collection-equality-checks
1920
- avoid-collection-methods-with-unrelated-types
2021
# - avoid-collection-mutating-methods # sometimes it's ok
2122
- avoid-conditions-with-boolean-literals
@@ -70,6 +71,7 @@ dart_code_metrics:
7071
- avoid-missing-enum-constant-in-map
7172
- avoid-misused-wildcard-pattern
7273
- avoid-mixing-named-and-positional-fields
74+
- avoid-multi-assignment
7375
# - avoid-mutating-parameters # we use ValueNotifier etc.
7476
# - avoid-negated-conditions # sometimes it might be better
7577
- avoid-nested-conditional-expressions:
@@ -147,6 +149,7 @@ dart_code_metrics:
147149
- avoid-unused-parameters
148150
- avoid-weak-cryptographic-algorithms
149151
- avoid-wildcard-cases-with-enums
152+
- prefer-switch-with-sealed-classes
150153
# - banned-usage # * OK, we just don't have global config
151154
- binary-expression-operand-order
152155
- double-literal-format
@@ -272,6 +275,8 @@ dart_code_metrics:
272275
- prefer-return-await
273276
# - prefer-returning-conditional-expressions # annoying sometimes
274277
- prefer-simpler-patterns-null-check
278+
- prefer-single-declaration-per-file:
279+
ignore-private: true
275280
- prefer-specific-cases-first
276281
- prefer-static-class:
277282
ignore-private: true
@@ -354,6 +359,11 @@ dart_code_metrics:
354359
- prefer-correct-bloc-provider
355360
- prefer-multi-bloc-provider
356361

362+
### Riverpod
363+
- avoid-ref-read-inside-build
364+
- avoid-ref-watch-outside-build
365+
- avoid-unnecessary-consumer-widgets
366+
357367
### Equatable
358368
# - extend-equatable # * OK, we just don't have global config
359369
- list-all-equatable-fields
@@ -378,7 +388,9 @@ dart_code_metrics:
378388
### Flutter Hooks
379389
- avoid-conditional-hooks
380390
- avoid-hooks-outside-build
391+
- avoid-misused-hooks
381392
- avoid-unnecessary-hook-widgets
393+
- prefer-use-callback
382394
- prefer-use-prefix
383395

384396
### Intl - not used

packages/netglade_analysis/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: netglade_analysis
2-
version: 10.0.0
2+
version: 11.0.0
33
description: Lint rules for Dart and Flutter used internally at netglade.
44
repository: https://github.com/netglade/flutter_core/tree/main/packages/netglade_analysis
55
issue_tracker: https://github.com/netglade/flutter_core/issues

0 commit comments

Comments
 (0)