Merge pull request #69 from netglade/dcm-1.27.0

netglade_analysis 16

Author: tenhobi

.fvm/fvm_config.json

@@ -1,3 +1,3 @@
 {
-  "flutter": "3.27.1"
+  "flutter": "3.29.0"
 }

.fvmrc

@@ -34,11 +34,17 @@ jobs:
       - name: Dart Analyze
         run: melos run lint:dart
 
+      - name: Get DCM version
+        id: dcm-version
+        run: |
+          dcmVersion=$(cat dcm_global.yaml | grep version | cut -d' ' -f2 | sed -r 's/"//g')
+          echo "DCM_VERSION=$dcmVersion" >> "$GITHUB_OUTPUT"
+
       - name: Install DCM
         uses: CQLabs/setup-dcm@v2
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
-          version: 1.26.2
+          version: ${{ steps.dcm-version.outputs.DCM_VERSION }}
 
       - name: Run DCM
         uses: CQLabs/dcm-action@v2

.github/workflows/ci.yaml

@@ -1,5 +1,5 @@
 {
-  "dart.flutterSdkPath": ".fvm/versions/3.27.1",
+  "dart.flutterSdkPath": ".fvm/versions/3.29.0",
   "search.exclude": {
     "**/.fvm": true,
     "**/*.g.dart": true

.vscode/settings.json

@@ -1 +1 @@
-version: "1.26.2"
+version: "1.27.1"

dcm_global.yaml

@@ -1,3 +1,11 @@
+## 16.0.0
+- Adhere to DCM 1.27.0:
+  - Add prefer-redirecting-superclass-constructor
+  - Add prefer-expect-later
+  - Add avoid-nested-try-statements
+  - Add avoid-unnecessary-block
+- Remove prefer_adjacent_string_concatenation from Dart lints
+
 ## 15.0.0
 - Adhere to DCM 1.26.0:
   - Add avoid-commented-out-code

packages/netglade_analysis/CHANGELOG.md

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2022 NetGlade
+Copyright (c) 2025 NetGlade
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

packages/netglade_analysis/LICENSE

@@ -23,7 +23,7 @@ To use the lints, add as a dev dependency in your `pubspec.yaml`:
 
 ```yaml
 dev_dependencies:
-  netglade_analysis: ^15.0.0
+  netglade_analysis: ^16.0.0
 ```
 
 Then, add an include in `analysis_options.yaml`:

packages/netglade_analysis/README.md

@@ -4,6 +4,7 @@ publish_to: none
 
 environment:
   sdk: ">=3.6.0 <4.0.0"
+resolution: workspace
 
 dependencies:
   netglade_analysis:

packages/netglade_analysis/example/pubspec.yaml

@@ -1,4 +1,4 @@
-# version 1.25.0 - https://dcm.dev/changelog
+# version 1.27.0 - https://dcm.dev/changelog
 dart_code_metrics:
   rules:
     ### Common
@@ -74,6 +74,7 @@ dart_code_metrics:
           - context.read
           - context.watch
           - GetIt.I
+          - Get.find
     - avoid-inverted-boolean-checks
     - avoid-keywords-in-wildcard-pattern
     # - avoid-late-keyword
@@ -103,6 +104,8 @@ dart_code_metrics:
     - avoid-nested-streams-and-futures
     - avoid-nested-switch-expressions
     - avoid-nested-switches
+    - avoid-nested-try-statements:
+        acceptable-level: 2
     - avoid-non-ascii-symbols:
         exclude:
           - test/**
@@ -155,6 +158,7 @@ dart_code_metrics:
     - avoid-uncaught-future-errors
     - avoid-unconditional-break
     - avoid-unknown-pragma
+    - avoid-unnecessary-block
     - avoid-unnecessary-call
     - avoid-unnecessary-collections
     - avoid-unnecessary-conditionals
@@ -334,6 +338,7 @@ dart_code_metrics:
     - prefer-declaring-const-constructor
     - prefer-early-return
     - prefer-enums-by-name
+    - prefer-expect-later
     - prefer-explicit-function-type
     - prefer-explicit-parameter-names
     # - prefer-explicit-type-arguments # inference is better
@@ -365,6 +370,7 @@ dart_code_metrics:
     # - prefer-prefixed-global-constants # * OK, we just don't have global config
     - prefer-private-extension-type-field
     - prefer-public-exception-classes
+    - prefer-redirecting-superclass-constructor
     - prefer-return-await
     # - prefer-returning-conditional-expressions # annoying sometimes
     - prefer-simpler-boolean-expressions

packages/netglade_analysis/lib/dcm.yaml

@@ -148,7 +148,7 @@ linter:
     # - package_api_docs
     - package_prefixed_library_names
     - parameter_assignments
-    - prefer_adjacent_string_concatenation
+    # - prefer_adjacent_string_concatenation # we don't like adjacent strings
     - prefer_asserts_in_initializer_lists
     - prefer_asserts_with_message
     - prefer_collection_literals

packages/netglade_analysis/lib/lints.yaml

@@ -1,5 +1,5 @@
 name: netglade_analysis
-version: 15.0.0
+version: 16.0.0
 description: Lint rules for Dart and Flutter used internally at netglade.
 repository: https://github.com/netglade/flutter_core/tree/main/packages/netglade_analysis
 issue_tracker: https://github.com/netglade/flutter_core/issues

packages/netglade_analysis/pubspec.yaml

@@ -5,11 +5,12 @@ publish_to: none
 environment:
   sdk: ^3.6.0
   flutter: ">=3.27.1"
+resolution: workspace
 
 dependencies:
   flutter:
     sdk: flutter
-  netglade_analysis: ^15.0.0
+  netglade_analysis: ^16.0.0
   netglade_flutter_utils:
     path: ..
 

packages/netglade_flutter_utils/example/pubspec.yaml

@@ -20,7 +20,7 @@ dev_dependencies:
   flutter_test:
     sdk: flutter
   mocktail: ^1.0.0
-  netglade_analysis: ^15.0.0
+  netglade_analysis: ^16.0.0
   test: ^1.25.8
 
 flutter:

packages/netglade_flutter_utils/pubspec.yaml

@@ -4,8 +4,9 @@ publish_to: none
 
 environment:
   sdk: ^3.6.0
+resolution: workspace
 
 dependencies:
-  netglade_analysis: ^15.0.0
+  netglade_analysis: ^16.0.0
   netglade_utils:
     path: ..

packages/netglade_utils/example/pubspec.yaml

@@ -18,5 +18,5 @@ dependencies:
   mocktail: ^1.0.0
 
 dev_dependencies:
-  netglade_analysis: ^15.0.0
+  netglade_analysis: ^16.0.0
   test: ^1.25.2

packages/netglade_utils/pubspec.yaml

@@ -5,11 +5,14 @@ environment:
   sdk: ^3.6.0
 workspace:
   - packages/netglade_analysis
+  - packages/netglade_analysis/example
   - packages/netglade_flutter_utils
+  - packages/netglade_flutter_utils/example
   - packages/netglade_utils
+  - packages/netglade_utils/example
 
 dev_dependencies:
-  melos: ^7.0.0-dev.3
+  melos: ^7.0.0-dev.7
 
 melos:
   scripts: