Skip to content

Commit 8364e8c

Browse files
committed
Update dcm
1 parent 7eb9777 commit 8364e8c

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
## 6.0.0
2-
- Enable DCM rule prefer-correct-error-name with `e` for error
3-
- Disable DCM rule banned-dependencies since we do not configure it (and add comment so we know it's ok)
2+
- Add DCM rule prefer-correct-error-name with `e` for error
3+
- Add DCM rule prefer-widget-private-members
4+
- Remove DCM rule banned-dependencies since we do not configure it (and add comment so we know it's ok)
45
- Adhere to DCM 1.11.0:
56
- TODO...
67

lib/dcm.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ dart_code_metrics:
66
- avoid-accessing-collections-by-constant-index
77
- avoid-accessing-other-classes-private-members
88
- avoid-async-call-in-sync-function
9-
# - avoid-banned-file-names # * OK, we just don't have global config
9+
# - avoid-banned-file-names # * OK, we just don't have global config
1010
# - avoid-banned-imports # * OK, we just don't have global config
1111
# - avoid-banned-types # * OK, we just don't have global config
1212
# - avoid-barrel-files # for now we use them
@@ -40,7 +40,7 @@ dart_code_metrics:
4040
# - avoid-long-files # hard to get the right settings
4141
# - avoid-long-functions # way too pedantic
4242
# - avoid-long-parameter-list: # way too pedantic
43-
# ignore-optional: true # exclude optional and (non-required) named parameters
43+
# ignore-optional: true # exclude optional and (non-required) named parameters
4444
- avoid-long-records
4545
- avoid-map-keys-contains
4646
- avoid-missed-calls
@@ -113,7 +113,7 @@ dart_code_metrics:
113113
- avoid-unused-parameters
114114
- avoid-weak-cryptographic-algorithms
115115
- avoid-wildcard-cases-with-enums
116-
# - banned-usage
116+
# - banned-usage # * OK, we just don't have global config
117117
- binary-expression-operand-order
118118
- double-literal-format
119119
- enum-constants-ordering
@@ -201,7 +201,7 @@ dart_code_metrics:
201201
- prefer-enums-by-name
202202
- prefer-explicit-parameter-names
203203
- prefer-first
204-
# - prefer-getter-over-method # way to pedantic
204+
# - prefer-getter-over-method # way too pedantic
205205
- prefer-immediate-return
206206
- prefer-iterable-of
207207
- prefer-last
@@ -213,7 +213,7 @@ dart_code_metrics:
213213
exclude:
214214
- test/**
215215
- prefer-named-boolean-parameters
216-
# - prefer-named-imports # ok, but we don't have a usecase now
216+
# - prefer-named-imports # * OK, we just don't have global config
217217
- prefer-parentheses-with-if-null
218218
- prefer-public-exception-classes
219219
- prefer-return-await
@@ -226,7 +226,7 @@ dart_code_metrics:
226226
- use(.*)
227227
- prefer-test-matchers
228228
- prefer-trailing-comma
229-
# - prefer-type-over-var # we prefer inference
229+
# - prefer-type-over-var # we prefer type inference
230230
# - prefer-unwrapping-future-or # we are ok with awaiting values
231231
- prefer-visible-for-testing-on-members
232232
- avoid-missing-interpolation:
@@ -271,7 +271,7 @@ dart_code_metrics:
271271
- prefer-sliver-prefix
272272
- prefer-text-rich
273273
- prefer-using-list-view
274-
# - prefer-widget-private-members # cannot use this.field in constructor
274+
- prefer-widget-private-members
275275
- proper-super-calls
276276
- use-setstate-synchronously
277277

@@ -304,10 +304,10 @@ dart_code_metrics:
304304
- prefer-custom-finder-over-find
305305
- prefer-symbol-over-key
306306

307-
## Fake Async
307+
### Fake Async
308308
- avoid-async-callback-in-fake-async
309309

310-
## Get It
310+
### Get It
311311
- avoid-functions-in-register-singleton:
312312
severity: error
313313

@@ -330,7 +330,7 @@ dart_code_metrics:
330330
# - avoid-dependency-overrides
331331
# - banned-dependencies # * OK, we just don't have global config
332332
- prefer-caret-version-syntax
333-
# - prefer-correct-package-name
333+
# - prefer-correct-package-name # * OK, we just don't have global config
334334
- prefer-correct-screenshots
335335
- prefer-publish-to-none
336336
- prefer-semver-version

0 commit comments

Comments
 (0)