Skip to content

Commit 80678b4

Browse files
authored
Merge pull request #5 from netglade/discord-link
Add Discord link
2 parents b2aaf53 + bc283df commit 80678b4

File tree

5 files changed

+37
-19
lines changed

5 files changed

+37
-19
lines changed

.github/workflows/ci.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
name: ci
22

33
on:
4-
pull_request:
54
push:
5+
branches:
6+
- main
7+
pull_request:
68

79
jobs:
810
build:

CHANGELOG.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,21 @@
1+
## 1.2.0
2+
- Remove `analyzer:exclude:` from `lints.yaml`. (add to README as a recommendation)
3+
- Add a Discord link to README.
4+
15
# 1.1.2
2-
- Enabled `format-comment`; issues with it were fixed.
6+
- Enable `format-comment`; issues with it were fixed.
37

48
# 1.1.1
59
- Configure `prefer-static-class` DCM rule exceptions for hooks and providers.
6-
- Disabled `format-comment` because of https://github.com/dart-code-checker/dart-code-metrics/issues/1158.
10+
- Disable `format-comment` because of https://github.com/dart-code-checker/dart-code-metrics/issues/1158.
711

812
# 1.1.0
913
- Add `prefer-static-class` DCM rule.
1014
- Add `use-setstate-synchronously` DCM rule.
1115
- Add `prefer-using-list-view` DCM rule.
12-
- Disabled `alphabetize` from `member-ordering` DCM rule.
13-
- **Breaking**: renamed `code_metrics.yaml` to `dcm.yaml`.
16+
- Disable `alphabetize` from `member-ordering` DCM rule.
17+
- **Breaking**: rename `code_metrics.yaml` to `dcm.yaml`.
1418

1519
# 1.0.0
1620

17-
- Add `analysis_options` and `code_metrics` used at [netglade](https://netglade.cz/en)
21+
- Add `analysis_options` and `code_metrics` used at [netglade](https://netglade.com/en)

README.md

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,20 @@
11
# netglade analysis
22

3-
<picture>
4-
<source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/netglade/.github/main/assets/netglade_logo_light.png">
5-
<source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/netglade/.github/main/assets/netglade_logo_dark.png">
6-
<img alt="netglade" src="https://raw.githubusercontent.com/netglade/.github/main/assets/netglade_logo_dark.png">
7-
</picture>
3+
<a href="https://netglade.com/en">
4+
<picture>
5+
<source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/netglade/.github/main/assets/netglade_logo_light.png">
6+
<source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/netglade/.github/main/assets/netglade_logo_dark.png">
7+
<img alt="netglade" src="https://raw.githubusercontent.com/netglade/.github/main/assets/netglade_logo_dark.png">
8+
</picture>
9+
</a>
810

911
Developed with 💚 by [netglade][netglade_link]
1012

1113
[![ci][ci_badge]][ci_badge_link]
1214
[![pub package][pub_badge]][pub_badge_link]
1315
[![license: MIT][license_badge]][license_badge_link]
1416
[![style: netglade analysis][style_badge]][style_badge_link]
17+
[![Discord][discord_badge]][discord_badge_link]
1518

1619
---
1720

@@ -47,6 +50,19 @@ dart_code_metrics:
4750
- package:netglade_analysis/dcm.yaml
4851
```
4952

53+
## Recommendations
54+
55+
Consider adding an analyzer exclude for generated, coverage, ... files.
56+
57+
```yaml
58+
analyzer:
59+
exclude:
60+
- '**/*.g.dart'
61+
- '**/*.freezed.dart'
62+
- test/.test_coverage.dart
63+
- lib/generated_plugin_registrant.dart
64+
```
65+
5066
## Badge
5167

5268
To indicate your project is using `netglade_analysis` →
@@ -56,7 +72,7 @@ To indicate your project is using `netglade_analysis` →
5672
[![style: netglade analysis](https://img.shields.io/badge/style-netglade_analysis-26D07C.svg)](https://pub.dev/packages/netglade_analysis)
5773
```
5874

59-
[netglade_link]: https://netglade.cz/en
75+
[netglade_link]: https://netglade.com/en
6076

6177
[ci_badge]: https://github.com/netglade/netglade_analysis/workflows/ci/badge.svg
6278
[ci_badge_link]: https://github.com/netglade/netglade_analysis/actions
@@ -66,6 +82,8 @@ To indicate your project is using `netglade_analysis` →
6682
[pub_badge_link]: https://pub.dartlang.org/packages/netglade_analysis
6783
[style_badge]: https://img.shields.io/badge/style-netglade_analysis-26D07C.svg
6884
[style_badge_link]: https://pub.dev/packages/netglade_analysis
85+
[discord_badge]: https://img.shields.io/discord/1091460081054400532.svg?logo=discord&color=blue
86+
[discord_badge_link]: https://discord.gg/sJfBBuDZy4
6987

7088
[linter_rules]: https://dart.dev/tools/linter-rules
7189
[supported_lint_rules]: https://dart-lang.github.io/linter/lints

lib/lints.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,6 @@ analyzer:
1515
unused_local_variable: warning
1616
deprecated_member_use_from_same_package: warning
1717

18-
exclude:
19-
- '**/*.g.dart'
20-
- '**/*.freezed.dart'
21-
- test/.test_coverage.dart
22-
- lib/generated_plugin_registrant.dart
23-
2418
linter:
2519
rules:
2620
### ERROR

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: netglade_analysis
2-
version: 1.1.2
2+
version: 1.2.0
33
description: Lint rules for Dart and Flutter used internally at netglade.
44
repository: https://github.com/netglade/netglade_analysis
55
issue_tracker: https://github.com/netglade/netglade_analysis/issues

0 commit comments

Comments
 (0)