Skip to content

Commit 36802f6

Browse files
committed
Update dcm rules
1 parent 5afec44 commit 36802f6

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.1.0
2+
- Adhere to DCM 1.7.0:
3+
-
4+
15
## 2.0.1
26
- Fix README logo
37

lib/dcm.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ dart_code_metrics:
3838
- avoid-generics-shadowing
3939
- avoid-global-state
4040
- avoid-ignoring-return-values
41-
- avoid-importing-entrypoint-exports
41+
# - avoid-importing-entrypoint-exports: false # TODO: has false positives in monorepo
4242
- avoid-inverted-boolean-checks
4343
- avoid-keywords-in-wildcard-pattern
4444
# - avoid-late-keyword
@@ -51,7 +51,7 @@ dart_code_metrics:
5151
- avoid-misused-wildcard-pattern
5252
- avoid-mixing-named-and-positional-fields
5353
# - avoid-mutating-parameters # we use ValueNotifier etc.
54-
- avoid-negated-conditions # TODO: ?
54+
# - avoid-negated-conditions # sometimes it might be better
5555
- avoid-nested-conditional-expressions:
5656
acceptable-level: 2
5757
- avoid-nested-futures
@@ -108,7 +108,9 @@ dart_code_metrics:
108108
only-doc-comments: true
109109
# - format-test-name # good but painful
110110
- function-always-returns-null
111-
- map-keys-ordering
111+
- map-keys-ordering:
112+
exclude:
113+
- test/**
112114
# - match-positional-field-names-on-assignment # not compatible with avoid-redundant-positional-field-name
113115
- member-ordering:
114116
order:
@@ -165,7 +167,7 @@ dart_code_metrics:
165167
- prefer-bytes-builder
166168
- prefer-commenting-analyzer-ignores
167169
- prefer-conditional-expressions
168-
- prefer-correct-error-name # TODO: we use `e`
170+
# - prefer-correct-error-name # we use `e`
169171
- prefer-correct-future-return-type
170172
# - prefer-correct-identifier-length # way too pedantic
171173
- prefer-correct-stream-return-type

0 commit comments

Comments
 (0)