Merge pull request #28 from netglade/remove-isBlank-on-nullable-string

Remove isBlank etc. on nullable String

Author: tenhobi

.fvm/fvm_config.json

@@ -0,0 +1,4 @@
+{
+  "flutterSdkVersion": "3.19.0",
+  "flavors": {}
+}

.gitignore

@@ -7,6 +7,7 @@ melos_my_project.iml
 .vscode/*
 !.vscode/tasks.json
 !.vscode/settings.json
+.fvm/flutter_sdk
 
 .packages
 .pub/

.vscode/settings.json

@@ -0,0 +1,31 @@
+{
+    "dart.flutterSdkPath": ".fvm/flutter_sdk",
+    "search.exclude": {
+        "**/.fvm": true,
+        "**/*.g.dart": true,
+    },
+    "files.exclude": {
+        "**/.git": true,
+        "**/.DS_Store": true,
+        ".idea/**": true,
+        ".run/**": true,
+    },
+    // Remove from file watching
+    "files.watcherExclude": {
+        "**/.fvm": true
+    },
+    "dart.lineLength": 120,
+    "editor.rulers": [
+        120
+    ],
+    "yaml.schemas": {
+        "https://json.schemastore.org/dart-build.json": [
+            "build.yaml"
+        ]
+    },
+    "explorer.fileNesting.enabled": true,
+    "explorer.fileNesting.patterns": {
+        "*.dart": "${capture}.g.dart,${capture}.freezed.dart,${capture}.auto_mappr.dart"
+    },
+    "yaml.schemaStore.enable": false
+}

packages/netglade_utils/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 2.0.0
+- Remove `isBlank`, `isNotBlank` from `String?` extension.
+
 ## 1.3.0
 - Add `distinctBy` to iterable extensions.
 

packages/netglade_utils/example/pubspec.yaml

@@ -6,6 +6,6 @@ environment:
   sdk: ^3.0.0
 
 dependencies:
-  netglade_analysis: ^7.0.0
+  netglade_analysis: ^8.0.0
   netglade_utils:
     path: ..

packages/netglade_utils/lib/src/extensions/string_extensions.dart

@@ -35,14 +35,6 @@ extension StringExtensions on String {
 }
 
 extension NullableStringExtensions on String? {
-  /// Returns true when `this` is `String` which is `isBlank`.
-  /// When the value is `null`, returns `false`.
-  ///
-  /// * String? is blank when it has a value and contains only whitespaces.
-  bool get isBlank {
-    return this?.isBlank ?? false;
-  }
-
   /// Returns true when `this` is either `null` or `isBlank`.
   ///
   /// * String? is blank when it has a value and contains only whitespaces.
@@ -55,13 +47,6 @@ extension NullableStringExtensions on String? {
     return !isNullOrBlank;
   }
 
-  /// Returns negation of [isBlank].
-  ///
-  /// * String? is blank when it has a value and contains only whitespaces.
-  bool get isNotBlank {
-    return !isBlank;
-  }
-
   /// Returns true when `this` is either `null` or `isBlank`.
   bool get isNullOrEmpty {
     return this?.isEmpty ?? true;

packages/netglade_utils/lib/src/testing/mock_extensions.dart

@@ -6,11 +6,13 @@ import 'package:mocktail/mocktail.dart';
 import 'package:netglade_utils/src/result/result.dart';
 
 extension FutureVoidAnswer on When<Future<void>> {
-  void thenAnswerWithVoid() => thenAnswer((_) async => <void>{});
+  // ignore: no-empty-block, its ok
+  void thenAnswerWithVoid() => thenAnswer((_) async {});
 }
 
 extension VoidAnswer on When<void> {
-  void thenAnswerWithVoid() => thenAnswer((_) => <void>{});
+  // ignore: no-empty-block, its ok
+  void thenAnswerWithVoid() => thenAnswer((_) {});
 }
 
 extension GenericAnswer<T> on When<Future<T>> {

packages/netglade_utils/pubspec.yaml

@@ -1,5 +1,5 @@
 name: netglade_utils
-version: 1.3.0
+version: 2.0.0
 description: Dart utils used internally at netglade.
 repository: https://github.com/netglade/flutter_core/tree/main/packages/netglade_utils
 issue_tracker: https://github.com/netglade/flutter_core/issues
@@ -17,5 +17,5 @@ dependencies:
   mocktail: ^1.0.0
 
 dev_dependencies:
-  netglade_analysis: ^7.0.0
+  netglade_analysis: ^8.0.0
   test: ^1.24.6

packages/netglade_utils/test/src/extensions/string_extensions_test.dart

@@ -43,22 +43,22 @@ void main() {
     group('on String?', () {
       test('empty message is isBlank', () {
         final String? value = '';
-        expect(value.isBlank, isTrue);
+        expect(value?.isBlank, isTrue);
       });
 
       test('null message is not isBlank', () {
         final String? value = null;
-        expect(value.isBlank, isFalse);
+        expect(value?.isBlank, isNull);
       });
 
       test('message with whitespaces is isBlank', () {
         final String? value = '   ';
-        expect(value.isBlank, isTrue);
+        expect(value?.isBlank, isTrue);
       });
 
       test('message with non-whitespace characters is not isBlank', () {
         final String? value = 'xxx';
-        expect(value.isBlank, isFalse);
+        expect(value?.isBlank, isFalse);
       });
     });
   });
@@ -84,22 +84,22 @@ void main() {
     group('on String?', () {
       test('empty message is not isNotBlank', () {
         final String? value = '';
-        expect(value.isNotBlank, isFalse);
+        expect(value?.isNotBlank, isFalse);
       });
 
-      test('message is null is isNotBlank', () {
+      test('message is null is null', () {
         final String? value = null;
-        expect(value.isNotBlank, isTrue);
+        expect(value?.isNotBlank, isNull);
       });
 
       test('message has whitespaces is not isNotBlank', () {
         final String? value = '   ';
-        expect(value.isNotBlank, isFalse);
+        expect(value?.isNotBlank, isFalse);
       });
 
       test('message has non-whitespace characters is isNotBlank', () {
         final String? value = 'xxx';
-        expect(value.isNotBlank, isTrue);
+        expect(value?.isNotBlank, isTrue);
       });
     });
   });