Skip to content

Commit 33e5f48

Browse files
committed
Dont check onSafe for check-is-not-closed-after-async-gap
1 parent 47abe51 commit 33e5f48

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

packages/netglade_analysis/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## 14.0.1
2+
- Don't check onSafe with check-is-not-closed-after-async-gap
3+
14
## 14.0.0
25
- Adhere to DCM 1.25.0:
36
- Add avoid-single-field-destructuring

packages/netglade_analysis/lib/dcm.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,9 +460,9 @@ dart_code_metrics:
460460
# - avoid-passing-bloc-to-bloc
461461
- avoid-passing-build-context-to-blocs
462462
- avoid-returning-value-from-cubit-methods
463-
- check-is-not-closed-after-async-gap:
464-
additional-methods:
465-
- onSafe
463+
- check-is-not-closed-after-async-gap
464+
# additional-methods:
465+
# - onSafe # ? Don't put onSafe here, it automatically checks whether bloc is closed in emit
466466
- emit-new-bloc-state-instances
467467
- handle-bloc-event-subclasses:
468468
additional-methods:

packages/netglade_analysis/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: netglade_analysis
2-
version: 14.0.0
2+
version: 14.0.1
33
description: Lint rules for Dart and Flutter used internally at netglade.
44
repository: https://github.com/netglade/flutter_core/tree/main/packages/netglade_analysis
55
issue_tracker: https://github.com/netglade/flutter_core/issues

0 commit comments

Comments
 (0)