Merge pull request #72 from netglade/feat/analysis-17.0.0

Author: tenhobi

dcm_global.yaml

@@ -1 +1 @@
-version: "1.27.1"
+version: "1.28.1"

packages/netglade_analysis/CHANGELOG.md

@@ -1,3 +1,17 @@
+## 17.0.0
+- Adhere to DCM 1.28.1
+  - Add avoid-recursive-tostring
+  - Add avoid-enum-values-by-index
+  - Add avoid-constant-assert-conditions
+  - Add avoid-nested-assignments
+  - Add avoid-unnecessary-compare-to
+  - Add prefer-digit-separators
+  - Add avoid-unnecessary-digit-separators
+  - Add avoid-inconsistent-digit-separators
+  - Add pass-existing-future-to-future-builder
+  - Add pass-existing-stream-to-stream-builder
+  - Add prefer-compute-over-isolate-run
+
 ## 16.1.0
 - Setup DCM Metrics
 

packages/netglade_analysis/README.md

@@ -23,7 +23,7 @@ To use the lints, add as a dev dependency in your `pubspec.yaml`:
 
 ```yaml
 dev_dependencies:
-  netglade_analysis: ^16.0.0
+  netglade_analysis: ^17.0.0
 ```
 
 Then, add an include in `analysis_options.yaml`:

packages/netglade_analysis/lib/dcm.yaml

@@ -27,6 +27,7 @@ dart_code_metrics:
     - avoid-complex-arithmetic-expressions
     - avoid-complex-loop-conditions
     - avoid-conditions-with-boolean-literals
+    - avoid-constant-assert-conditions
     # - avoid-continue # we prefer condition guards
     - avoid-contradictory-expressions
     - avoid-declaring-call-method
@@ -48,6 +49,7 @@ dart_code_metrics:
         include-methods:
           - blocTest
           - blocPresentationTest
+    - avoid-enum-values-by-index
     - avoid-equal-expressions
     - avoid-excessive-expressions
     - avoid-explicit-pattern-field-name
@@ -68,6 +70,7 @@ dart_code_metrics:
           - test/**
     - avoid-implicitly-nullable-extension-types
     - avoid-importing-entrypoint-exports
+    - avoid-inconsistent-digit-separators
     - avoid-incorrect-uri
     - avoid-inferrable-type-arguments:
         ignored-invocations:
@@ -96,6 +99,7 @@ dart_code_metrics:
     # - avoid-mutating-parameters # we use ValueNotifier etc.
     # - avoid-negated-conditions # sometimes it might be better
     - avoid-negations-in-equality-checks
+    - avoid-nested-assignments
     - avoid-nested-conditional-expressions:
         acceptable-level: 2
     - avoid-nested-extension-types
@@ -128,6 +132,7 @@ dart_code_metrics:
     - avoid-passing-self-as-argument
     - avoid-positional-record-field-access
     - avoid-recursive-calls
+    - avoid-recursive-tostring
     - avoid-redundant-async
     - avoid-redundant-else
     - avoid-redundant-positional-field-name
@@ -161,9 +166,11 @@ dart_code_metrics:
     - avoid-unnecessary-block
     - avoid-unnecessary-call
     - avoid-unnecessary-collections
+    - avoid-unnecessary-compare-to
     - avoid-unnecessary-conditionals
     - avoid-unnecessary-constructor
     - avoid-unnecessary-continue
+    - avoid-unnecessary-digit-separators
     - avoid-unnecessary-enum-arguments
     - avoid-unnecessary-enum-prefix
     - avoid-unnecessary-extends
@@ -336,6 +343,7 @@ dart_code_metrics:
     # - prefer-correct-throws # for now hard to maintain
     - prefer-correct-type-name
     - prefer-declaring-const-constructor
+    - prefer-digit-separators
     - prefer-early-return
     - prefer-enums-by-name
     - prefer-expect-later
@@ -437,9 +445,12 @@ dart_code_metrics:
     - check-for-equals-in-render-object-setters
     - consistent-update-render-object
     - dispose-fields
+    - pass-existing-future-to-future-builder
+    - pass-existing-stream-to-stream-builder
     - prefer-action-button-tooltip
     - prefer-align-over-container
     - prefer-center-over-align
+    - prefer-compute-over-isolate-run
     - prefer-const-border-radius
     - prefer-container:
         min-sequence: 2

packages/netglade_analysis/pubspec.yaml

@@ -1,5 +1,5 @@
 name: netglade_analysis
-version: 16.1.0
+version: 17.0.0
 description: Lint rules for Dart and Flutter used internally at netglade.
 repository: https://github.com/netglade/flutter_core/tree/main/packages/netglade_analysis
 issue_tracker: https://github.com/netglade/flutter_core/issues

packages/netglade_flutter_utils/example/pubspec.yaml

@@ -10,7 +10,7 @@ resolution: workspace
 dependencies:
   flutter:
     sdk: flutter
-  netglade_analysis: ^16.0.0
+  netglade_analysis: ^17.0.0
   netglade_flutter_utils:
     path: ..
 

packages/netglade_flutter_utils/pubspec.yaml

@@ -20,7 +20,7 @@ dev_dependencies:
   flutter_test:
     sdk: flutter
   mocktail: ^1.0.0
-  netglade_analysis: ^16.0.0
+  netglade_analysis: ^17.0.0
   test: ^1.25.8
 
 flutter:

packages/netglade_utils/example/pubspec.yaml

@@ -7,6 +7,6 @@ environment:
 resolution: workspace
 
 dependencies:
-  netglade_analysis: ^16.0.0
+  netglade_analysis: ^17.0.0
   netglade_utils:
     path: ..

packages/netglade_utils/pubspec.yaml

@@ -18,5 +18,5 @@ dependencies:
   mocktail: ^1.0.0
 
 dev_dependencies:
-  netglade_analysis: ^16.0.0
+  netglade_analysis: ^17.0.0
   test: ^1.25.2