NGSTACK-995 update PHPUnit to version 12, migrate 'phpunit.xml' file to a newer version and fix some tests

Ante Prkacin · Ante Prkacin · commit 1e95b15c5f60 · 2025-10-23T13:14:39.000+02:00
diff --git a/composer.json b/composer.json
@@ -21,7 +21,7 @@
         "twig/twig": "^3.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^9.0",
+        "phpunit/phpunit": "^12.0",
         "netgen/ibexa-forms-bundle": "^5.0",
         "friendsofphp/php-cs-fixer": "^3.3",
         "ibexa/solr": "^5.0"
diff --git a/phpunit.xml b/phpunit.xml
@@ -2,17 +2,25 @@
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          bootstrap="vendor/autoload.php"
          backupGlobals="false"
-         backupStaticAttributes="false"
-         convertErrorsToExceptions="true"
-         convertNoticesToExceptions="true"
-         convertWarningsToExceptions="true"
          colors="true"
-         verbose="true"
          processIsolation="false"
          stopOnFailure="false"
          beStrictAboutTestsThatDoNotTestAnything="false"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
-    <coverage>
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/12.4/phpunit.xsd"
+         cacheDirectory=".phpunit.cache"
+         backupStaticProperties="false"
+>
+    <testsuites>
+        <testsuite name="Netgen\EnhancedSelectionBundle\Tests">
+            <directory>tests</directory>
+        </testsuite>
+    </testsuites>
+
+    <logging>
+        <junit outputFile="build/report.junit.xml"/>
+    </logging>
+
+    <source>
         <include>
             <directory suffix=".php">bundle</directory>
         </include>
@@ -24,18 +32,5 @@
             <file>bundle/Core/FieldType/EnhancedSelection/SearchField.php</file>
             <file>bundle/NetgenEnhancedSelectionBundle.php</file>
         </exclude>
-        <report>
-            <clover outputFile="build/logs/clover.xml"/>
-            <html outputDirectory="build/coverage"/>
-            <text outputFile="build/coverage.txt"/>
-        </report>
-    </coverage>
-    <testsuites>
-        <testsuite name="Netgen\EnhancedSelectionBundle\Tests">
-            <directory>tests</directory>
-        </testsuite>
-    </testsuites>
-    <logging>
-        <junit outputFile="build/report.junit.xml"/>
-    </logging>
+    </source>
 </phpunit>
diff --git a/tests/Core/FieldType/EnhancedSelection/EnhancedSelectionStorageTest.php b/tests/Core/FieldType/EnhancedSelection/EnhancedSelectionStorageTest.php
@@ -60,7 +60,7 @@ public function testStoreFieldData(): void
             ]
         );
 
-        $connection = $this->getMockForAbstractClass(StorageGateway::class);
+        $connection = $this->createMock(StorageGateway::class);
         $context = ['identifier' => 'enhancedselection', 'connection' => $connection];
 
         $this->gateway->expects(self::once())
@@ -86,7 +86,7 @@ public function testGetFieldData(): void
             ]
         );
 
-        $connection = $this->getMockForAbstractClass(StorageGateway::class);
+        $connection = $this->createMock(StorageGateway::class);
         $context = ['identifier' => 'enhancedselection', 'connection' => $connection];
 
         $this->gateway->expects(self::once())
@@ -100,7 +100,7 @@ public function testDeleteFieldData(): void
         $versionInfo = new VersionInfo();
         $fields = ['some_field'];
 
-        $connection = $this->getMockForAbstractClass(StorageGateway::class);
+        $connection = $this->createMock(StorageGateway::class);
         $context = ['identifier' => 'enhancedselection', 'connection' => $connection];
 
         $this->gateway->expects(self::once())
diff --git a/tests/Templating/Twig/NetgenEnhancedSelectionRuntimeTest.php b/tests/Templating/Twig/NetgenEnhancedSelectionRuntimeTest.php
@@ -25,10 +25,7 @@ final class NetgenEnhancedSelectionRuntimeTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->contentTypeService = $this->getMockBuilder(ContentTypeService::class)
-            ->disableOriginalConstructor()
-            ->onlyMethods(['loadContentType'])
-            ->getMockForAbstractClass();
+        $this->contentTypeService = $this->createMock(ContentTypeService::class);
 
         $this->runtime = new NetgenEnhancedSelectionRuntime($this->contentTypeService);
     }

Original file line number	Diff line number	Diff line change
`@@ -25,10 +25,7 @@ final class NetgenEnhancedSelectionRuntimeTest extends TestCase`
`25`	`25`
`26`	`26`	`protected function setUp(): void`
`27`	`27`	`{`
`28`		`- $this->contentTypeService = $this->getMockBuilder(ContentTypeService::class)`
`29`		`- ->disableOriginalConstructor()`
`30`		`- ->onlyMethods(['loadContentType'])`
`31`		`- ->getMockForAbstractClass();`
	`28`	`+ $this->contentTypeService = $this->createMock(ContentTypeService::class);`
`32`	`29`
`33`	`30`	`$this->runtime = new NetgenEnhancedSelectionRuntime($this->contentTypeService);`
`34`	`31`	`}`