relation "dcim_cabletermination_unique_termination" already exists

[jakub-krysl-ipf]

Plugin Version

0.5.5

NetBox Version

4.2.6

Python Version

3.12.3

Steps to Reproduce

1. Try to provision branch

Expected Behavior

Branch provisioned

Observed Behavior

relation "dcim_cabletermination_unique_termination" already exists

Stack Trace: `Traceback (most recent call last): File "/opt/netbox/venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 103, in _execute return self.cursor.execute(sql) ^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/netbox/venv/lib/python3.12/site-packages/psycopg/cursor.py", line 97, in execute raise ex.with_traceback(None) psycopg.errors.DuplicateTable: relation "dcim_cabletermination_unique_termination" already exists

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "/source/ipfabric_netbox/models.py", line 709, in sync
    branch.provision(user=user)
File "/opt/netbox/venv/lib/python3.12/site-packages/netbox_branching/models/branches.py", line 608, in provision
    raise e
File "/opt/netbox/venv/lib/python3.12/site-packages/netbox_branching/models/branches.py", line 591, in provision
    raise e
File "/opt/netbox/venv/lib/python3.12/site-packages/netbox_branching/models/branches.py", line 587, in provision
    cursor.execute(sql)
File "/opt/netbox/venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 79, in execute return
    self._execute_with_wrappers( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/netbox/venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 92, in _execute_with_wrappers
    return executor(sql, params, many, context) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/netbox/venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 100, in _execute with
    self.db.wrap_database_errors:
File "/opt/netbox/venv/lib/python3.12/site-packages/django/db/utils.py", line 91, in exit
    raise dj_exc_value.with_traceback(traceback) from exc_value
File "/opt/netbox/venv/lib/python3.12/site-packages/django/db/backends/utils.py", line 103, in _execute
    return self.cursor.execute(sql) ^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/netbox/venv/lib/python3.12/site-packages/psycopg/cursor.py", line 97, in execute
    raise ex.with_traceback(None)
django.db.utils.ProgrammingError: relation "dcim_cabletermination_unique_termination" already exists

netbox-worker_1  | 2025-05-16T18:23:41.994463876Z DEBUG ALTER INDEX branch_tg0w3gki.dcim_cabletermination_termination_type_id_termination_id_key RENAME TO dcim_cabletermination_unique_termination                
netbox-worker_1  | 2025-05-16T18:23:42.028738399Z ERROR ALTER INDEX branch_tg0w3gki.dcim_cabletermination_termination_type_id_termination_id_idx RENAME TO dcim_cabletermination_unique_termination                
netbox-worker_1  | 2025-05-16T18:23:42.029611384Z ERROR relation "dcim_cabletermination_unique_termination" already exists 

[jnovinger]

@jakub-krysl-ipf , I'm not able to reproduce this. Can you narrow down the steps to reproduce? Trying this with Netbox 4.2.6 and netbox-branching 0.5.5, I'm not having any problems provisioning branches.

[jakub-krysl-ipf]

@jakub-krysl-ipf , I'm not able to reproduce this. Can you narrow down the steps to reproduce? Trying this with Netbox 4.2.6 and netbox-branching 0.5.5, I'm not having any problems provisioning branches.

Maybe it needs to be called directly?
I hit this after upgrade from 0.5.4 to 0.5.5 in ipfabric_netbox plugin. It runs a Job where it creates Branch, assigns the branch to custom model (models.OneToOneField) and than it provisions it manually using branch.provision(user=user).

branch = Branch(name="test")
branch.save(provision=False)
branch.provision()

[k-masters]

I'm having this same issue. I opened discussion #258 the other day.
Netbox version v4.2.8
Netbox branching v0.5.5
Python 3.11.11

Brand new install of netbox-branching and I encountered this error on the first branch I tried to create. The end of the create branch job looks just like the above. I'm not sure how to pull they python stack trace or I'd include mine as well.

[jakub-krysl-ipf]

I think the issue is caused by the last migration ignoring these indexes:

netbox-branching/netbox_branching/migrations/0003_rename_indexes.py

Lines 8 to 13 in 48005bd

	# Indexes to ignore as they are removed in a NetBox v4.3 migration
	SKIP = (
	'dcim_cabletermination_termination_type_id_termination_id_idx', # Removed in dcim.0207_remove_redundant_indexes
	'vpn_l2vpntermination_assigned_object_type_id_assigned_objec_idx', # Removed in vpn.0009_remove_redundant_indexes
	'vpn_tunneltermination_termination_type_id_termination_id_idx', # Removed in vpn.0009_remove_redundant_indexes
	)

I don't know enough about the DB indexing, so it's only my guess skipping these on <v4.3.0 causes this issue.

[jeremystretch]

ALTER INDEX branch_wbhcnb41.dcim_cabletermination_termination_type_id_termination_id_key RENAME TO dcim_cabletermination_unique_termination
ALTER INDEX branch_wbhcnb41.dcim_cabletermination_termination_type_id_termination_id_idx RENAME TO dcim_cabletermination_unique_termination

This is due to a duplicate index on the dcim_cabletermination table. This index (and two others) are removed in NetBox v4.3.0 (see #18191) but are still present in v4.2.x. As you can see above, the plugin attempts to rename both indexes to the same name, resulting in the error.

I think we can just omit these inside the provision() as we do in the database migration to work around the error.