Logging message when creating via API

[GillesTondini]

Hi,

When using the logger netbox.views.ObjectEditView , we have the name of the created object in the message
e.g "Created prefix 192.168.0.0/29 (PK: 15654)"

but when using the API, the message is a more generic "Creating new prefix"

We do have however the name of the object when updating, both via the API and the GUI:

"Modified prefix 192.168.0.0/29 (PK: 13804)" (GUI)
"Updating prefix 192.168.0.0/29 (PK: 15653)" (API)

Any reason it's not the same for every action?

Thanks,

[candlerb]

It looks to me like the messages could be made more consistent - see below.

However the "Creating" message is logged before object creation for the API, and the "Created" message after creation for the web interface. That's why the primary key isn't shown.

netbox/views/generic.py

class ObjectEditView
...
    def post(self, request, *args, **kwargs):
...
           try:
                with transaction.atomic():
                    object_created = form.instance.pk is None
                    obj = form.save()

                    # Check that the new object conforms with any assigned object-level permissions
                    if not self.queryset.filter(pk=obj.pk).first():
                        raise PermissionsViolation()

                msg = '{} {}'.format(
                    'Created' if object_created else 'Modified',
                    self.queryset.model._meta.verbose_name
                )
                logger.info(f"{msg} {obj} (PK: {obj.pk})")

netbox/api/views.py

   def perform_create(self, serializer):
        model = self.queryset.model
        logger = logging.getLogger('netbox.api.views.ModelViewSet')
        logger.info(f"Creating new {model._meta.verbose_name}")

        # Enforce object-level permissions on save()
        try:
            with transaction.atomic():
                instance = serializer.save()
                self._validate_objects(instance)
        except ObjectDoesNotExist:
            raise PermissionDenied()
...
    def perform_update(self, serializer):
        model = self.queryset.model
        logger = logging.getLogger('netbox.api.views.ModelViewSet')
        logger.info(f"Updating {model._meta.verbose_name} {serializer.instance} (PK: {serializer.instance.pk})")