Filterform does not apply filter to list

[madgrizzle]

I'm very new to Netbox and django in general, but I've exhausted everything I could find to help me with this problem. I'm evaluating Netbox for an application and am trying to create a plugin for tracking some information about facilities. I've constructed a model but when I try to filter it using FilterForm tab, the results that are returned or still unfiltered. I don't know what mechanism is used to do the filtering so I'm struggling in figuring out my problem.

Model:

class FacilityAsset(PrimaryModel):
    site = models.ForeignKey(
        to='dcim.Site',
        blank=True,
        null=True,
        on_delete=models.PROTECT,
        related_name='facilityassets',
    )     

    parent = models.ForeignKey(
        to='netbox_facilities.FacilityAsset',
        blank=True,
        null=True,
        on_delete=models.PROTECT
    )
    name = models.CharField(max_length=50,verbose_name=_('asset name'))
    install_date = models.DateField(blank=True, null=True, verbose_name=_('installation date'))
    serial_number = models.CharField(max_length=50, blank=True, verbose_name=_('serial number'))
    fdot_tag_number = models.CharField(max_length=50, blank=True, verbose_name=_('fdot tag number'))
    tenant = models.ForeignKey(
        to='tenancy.Tenant',
        on_delete=models.PROTECT,
        related_name='facilityassets',
        blank=True,
        null=True
    )

    class Meta:
        ordering = ("site", "name", "tenant", "install_date", "serial_number", "fdot_tag_number")
        constraints = [
            CheckConstraint(check=~Q(id=models.F('parent_id')), name='prevent_self_reference')
        ]
        
    def __str__(self):
        return f'{self.site.name} - {self.name}'

    def get_absolute_url(self):
        return reverse("plugins:netbox_facilities:facilityasset", args=[self.pk])

FilterForm:

class FacilityAssetFilterForm(TenancyFilterForm, NetBoxModelFilterSetForm):
    model = FacilityAsset
  
    region_id = DynamicModelChoiceField(
        queryset=Region.objects.all(),
        required=False,
    )
    site_group_id = DynamicModelChoiceField(
        queryset=SiteGroup.objects.all(),
        required=False,
        label="Site Group",
    )
    site_id = DynamicModelChoiceField(
        queryset = Site.objects.all(),
        required = False,
        label = _("Site"),
        query_params={"region_id": "$region", "group_id": "$site_group"},
    )

    fieldsets = (
        FieldSet('region_id', 'site_group_id', 'site_id',  name=_('Attributes')),
        FieldSet('tenant_group_id', 'tenant_id', name=_('Tenant'))
    )

View:

@register_model_view(FacilityAsset, 'list', path='', detail=False)
class FacilityAssetListView(generic.ObjectListView):
    print("here")
    queryset = FacilityAsset.objects.all()#prefetch_related("tags")
    filterset = FacilityAssetFilterSet
    filterset_form = FacilityAssetFilterForm
    table = tables.FacilityAssetTable

FilterSet (not sure this is relevant to the type of filter because everything is the same if I include it the view above or not..)

class FacilityAssetFilterSet(NetBoxModelFilterSet):
      
    site = django_filters.ModelMultipleChoiceFilter(
        field_name='site__name',
        queryset=Site.objects.all(),
        to_field_name='name',
        label=_('Site'),
    )
    
    class Meta:
        model = FacilityAsset
        fields = (
            'id', 'name'
        )
    
    def search(self, queryset, name, value):
        if not value.strip():
            return queryset
        return queryset.filter(
            Q(name__icontains=value) 
        )

I get the FilterForm tab and select one the site I want to filter on:

After pressing save, it goes back put the form is not filtered even though I can see in the url the ?site=1 is being passed.

I don't really know where to look as I can't find a lot of information on the FilterForm (or people with such an issue either). I'm sure its something simple, but I've spent hours to no avail. Any help would be appreciated. Thanks.

[madgrizzle]

I swore I tried this first, maybe I had something wrong and ended up going down a rabbithole... but this was the solution (add site_id to the FilterSet)...

class FacilityAssetFilterSet(NetBoxModelFilterSet):
      
    site_id = django_filters.ModelMultipleChoiceFilter(
        queryset = Site.objects.all(),
        label=_('Site (ID)'),
    )
    site = django_filters.ModelMultipleChoiceFilter(
        field_name='site__name',
        queryset=Site.objects.all(),
        to_field_name='name',
        label=_('Site name'),
    )
    
    class Meta:
        model = FacilityAsset
        fields = (
            'id', 'name'
        )
    
    def search(self, queryset, name, value):
        if not value.strip():
            return queryset
        return queryset.filter(
            Q(name__icontains=value) 
        )