Skip to content

Commit 135199e

Browse files
authored
Merge branch 'master' into patch-2
2 parents 6568dff + c083baf commit 135199e

File tree

10 files changed

+206
-53
lines changed

10 files changed

+206
-53
lines changed

.dockerignore

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
.git
12
.github
23
.travis.yml
4+
*.md
5+
env
36
build*
4-
*.env
5-
.git
7+
docker-compose.override.yml

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,22 @@ The output of `docker version`: `XXXXX`
4545
The output of `git rev-parse HEAD`: `XXXXX`
4646
The command you used to start the project: `XXXXX`
4747

48+
<!-- adjust the `latest` tag to the version you're using -->
49+
The output of `docker inspect netboxcommunity/netbox:latest --format "{{json .ContainerConfig.Labels}}"`:
50+
51+
```json
52+
{
53+
"JSON JSON JSON":
54+
"--> Please paste formatted json. (Use e.g. `jq` or https://jsonformatter.curiousconcept.com/)"
55+
}
56+
```
57+
4858
The output of `docker-compose logs netbox`:
4959
<!--
5060
If your log is very long, create a Gist instead (and post the link to it): https://gist.github.com
5161
-->
5262

53-
```
63+
```text
5464
LOG LOG LOG
5565
```
5666

@@ -60,6 +70,6 @@ Only if you have gotten a 5xx http error, else delete this section.
6070
If your log is very long, create a Gist instead (and post the link to it): https://gist.github.com
6171
-->
6272

63-
```
73+
```text
6474
LOG LOG LOG
6575
```
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
---
2+
name: Feature or Change Request
3+
about: Request a new feature or a change of the current behavior
4+
title: ''
5+
labels: ''
6+
assignees: ''
7+
8+
---
9+
10+
<!--
11+
12+
Before raising an issue here, answer the following questions for yourself, please:
13+
14+
* Did you read through the troubleshooting section? (https://github.com/netbox-community/netbox-docker/wiki/Troubleshooting)
15+
* Have you had a look at the rest of the wiki? (https://github.com/netbox-community/netbox-docker/wiki)
16+
* Have you read the release notes recently (https://github.com/netbox-community/netbox-docker/releases)
17+
* Are you confident that your feature/change request is related to the Docker image or Docker Compose file this project provides?
18+
(Otherwise ask on the Netbox mailing list, please: https://groups.google.com/d/forum/netbox-discuss)
19+
* Have you looked through the issues already resolved?
20+
21+
Please try this means to get help before opening an issue here:
22+
23+
* On the networktocode Slack in the #netbox-docker channel: http://slack.networktocode.com/
24+
* On the networktocode Slack in the #netbox channel: http://slack.networktocode.com/
25+
* On the Netbox mailing list: https://groups.google.com/d/forum/netbox-discuss
26+
27+
-->
28+
29+
## Desired Behavior
30+
31+
<!-- please describe the behavior you desire -->
32+
...
33+
34+
## Contrast to Current Behavior
35+
36+
<!-- please describe how the desired behavior is different to the current behavior -->
37+
...
38+
39+
## Changes Required
40+
41+
<!-- if you can, please elaborate what changes would exactly be required -->
42+
...
43+
44+
## Discussion: Benefits and Drawbacks
45+
46+
<!--
47+
Please make your case here:
48+
- Why do you think this project and the community will benefit from your suggestion?
49+
- What are the drawbacks of this change? Is it backwards-compatible?
50+
- Anything else that you think is relevant to the discussion of this feature/change request.
51+
-->
52+
...

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
*.sql.gz
22
.netbox
3+
docker-compose.override.yml

Dockerfile

Lines changed: 29 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ WORKDIR /install
1818

1919
RUN pip install --prefix="/install" --no-warn-script-location \
2020
# gunicorn is used for launching netbox
21-
gunicorn \
21+
'gunicorn<20.0.0' \
2222
greenlet \
2323
eventlet \
2424
# napalm is used for gathering information from network devices
@@ -72,11 +72,34 @@ ENTRYPOINT [ "/opt/netbox/docker-entrypoint.sh" ]
7272

7373
CMD ["gunicorn", "-c /etc/netbox/config/gunicorn_config.py", "netbox.wsgi"]
7474

75-
LABEL NETBOX_DOCKER_PROJECT_VERSION="custom build" \
76-
NETBOX_BRANCH="custom build" \
77-
ORIGINAL_DOCKER_TAG="custom build" \
78-
NETBOX_GIT_COMMIT="not built from git" \
79-
NETBOX_GIT_URL="not built from git"
75+
LABEL ORIGINAL_TAG="" \
76+
NETBOX_GIT_BRANCH="" \
77+
NETBOX_GIT_REF="" \
78+
NETBOX_GIT_URL="" \
79+
# See http://label-schema.org/rc1/#build-time-labels
80+
# Also https://microbadger.com/labels
81+
org.label-schema.schema-version="1.0" \
82+
org.label-schema.build-date="" \
83+
org.label-schema.name="Netbox Docker" \
84+
org.label-schema.description="A container based distribution of Netbox, the free and open IPAM and DCIM solution." \
85+
org.label-schema.vendor="The netbox-docker contributors." \
86+
org.label-schema.url="https://github.com/netbox-community/netbox-docker" \
87+
org.label-schema.usage="https://github.com/netbox-community/netbox-docker/wiki" \
88+
org.label-schema.vcs-url="https://github.com/netbox-community/netbox-docker.git" \
89+
org.label-schema.vcs-ref="" \
90+
org.label-schema.version="snapshot" \
91+
# See https://github.com/opencontainers/image-spec/blob/master/annotations.md#pre-defined-annotation-keys
92+
org.opencontainers.image.created="" \
93+
org.opencontainers.image.title="Netbox Docker" \
94+
org.opencontainers.image.description="A container based distribution of Netbox, the free and open IPAM and DCIM solution." \
95+
org.opencontainers.image.licenses="Apache-2.0" \
96+
org.opencontainers.image.authors="The netbox-docker contributors." \
97+
org.opencontainers.image.vendor="The netbox-docker contributors." \
98+
org.opencontainers.image.url="https://github.com/netbox-community/netbox-docker" \
99+
org.opencontainers.image.documentation="https://github.com/netbox-community/netbox-docker/wiki" \
100+
org.opencontainers.image.source="https://github.com/netbox-community/netbox-docker.git" \
101+
org.opencontainers.image.revision="" \
102+
org.opencontainers.image.version="snapshot"
80103

81104
#####
82105
## LDAP specific configuration

README.md

Lines changed: 39 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,45 @@
11
# netbox-docker
22

3+
[![GitHub release (latest by date)](https://img.shields.io/github/v/release/netbox-community/netbox-docker)][github-release]
4+
[![GitHub stars](https://img.shields.io/github/stars/netbox-community/netbox-docker)][github-stargazers]
5+
![GitHub closed pull requests](https://img.shields.io/github/issues-pr-closed-raw/netbox-community/netbox-docker)
6+
![Docker Cloud Build Status](https://img.shields.io/docker/cloud/build/netboxcommunity/netbox)
7+
![Docker Pulls](https://img.shields.io/docker/pulls/netboxcommunity/netbox)
8+
[![MicroBadger Layers](https://img.shields.io/microbadger/layers/netboxcommunity/netbox)][netbox-docker-microbadger]
9+
[![MicroBadger Size](https://img.shields.io/microbadger/image-size/netboxcommunity/netbox)][netbox-docker-microbadger]
10+
[![GitHub license](https://img.shields.io/github/license/netbox-community/netbox-docker)][netbox-docker-license]
11+
312
[The Github repository](netbox-docker-github) houses the components needed to build Netbox as a Docker container.
413
Images are built using this code and are released to [Docker Hub][netbox-dockerhub] once a day.
514

615
Do you have any questions? Before opening an issue on Github, please join the [Network To Code][ntc-slack] Slack and ask for help in our [`#netbox-docker`][netbox-docker-slack] channel.
716

17+
[github-stargazers]: https://github.com/netbox-community/netbox-docker/stargazers
18+
[github-release]: https://github.com/netbox-community/netbox-docker/releases
19+
[netbox-docker-microbadger]: https://microbadger.com/images/netboxcommunity/netbox
820
[netbox-dockerhub]: https://hub.docker.com/r/netboxcommunity/netbox/tags/
921
[netbox-docker-github]: https://github.com/netbox-community/netbox-docker/
1022
[ntc-slack]: http://slack.networktocode.com/
1123
[netbox-docker-slack]: https://slack.com/app_redirect?channel=netbox-docker&team=T09LQ7E9E
24+
[netbox-docker-license]: https://github.com/netbox-community/netbox-docker/blob/master/LICENSE
25+
26+
## Docker Tags
27+
28+
* `vX.Y.Z`: Release builds, built from [releases of Netbox][netbox-releases].
29+
* `latest`: Release builds, built from [`master` branch of Netbox][netbox-master].
30+
* `snapshot`: Pre-release builds, built from the [`develop` branch of Netbox][netbox-develop].
31+
* `develop-X.Y`: Pre-release builds, built from the corresponding [branch of Netbox][netbox-branches].
32+
33+
Then there is currently one extra tags for each of the above labels:
34+
35+
* `-ldap`: Contains additional dependencies and configurations for connecting Netbox to an LDAP directroy.
36+
[Learn more about that in our wiki][netbox-docker-ldap].
37+
38+
[netbox-releases]: https://github.com/netbox-community/netbox/releases
39+
[netbox-master]: https://github.com/netbox-community/netbox/tree/master
40+
[netbox-develop]: https://github.com/netbox-community/netbox/tree/develop
41+
[netbox-branches]: https://github.com/netbox-community/netbox/branches
42+
[netbox-docker-ldap]: https://github.com/netbox-community/netbox-docker/wiki/LDAP
1243

1344
## Quickstart
1445

@@ -54,12 +85,12 @@ This project relies only on *Docker* and *docker-compose* meeting this requireme
5485

5586
To ensure this, compare the output of `docker --version` and `docker-compose --version` with the requirements above.
5687

57-
## Reference Documentation
88+
## Documentation
5889

59-
Please refer [to the wiki][wiki] for further information on how to use this Netbox Docker image properly.
90+
Please refer [to our wiki on Github][netbox-docker-wiki] for further information on how to use this Netbox Docker image properly.
6091
It covers advanced topics such as using secret files, deployment to Kubernetes as well as NAPALM and LDAP configuration.
6192

62-
[wiki]: https://github.com/netbox-community/netbox-docker/wiki/
93+
[netbox-docker-wiki]: https://github.com/netbox-community/netbox-docker/wiki/
6394

6495
## Netbox Version
6596

@@ -69,7 +100,7 @@ To use this feature, set the environment-variable `VERSION` before launching `do
69100
[any tag of the `netboxcommunity/netbox` Docker image on Docker Hub][netbox-dockerhub].
70101

71102
```bash
72-
export VERSION=v2.6.6
103+
export VERSION=v2.6.7
73104
docker-compose pull netbox
74105
docker-compose up -d
75106
```
@@ -78,7 +109,7 @@ You can also build a specific version of the Netbox Docker image yourself.
78109
`VERSION` can be any valid [git ref][git-ref] in that case.
79110

80111
```bash
81-
export VERSION=v2.6.6
112+
export VERSION=v2.6.7
82113
./build.sh $VERSION
83114
docker-compose up -d
84115
```
@@ -90,8 +121,9 @@ docker-compose up -d
90121

91122
From time to time it might become necessary to re-engineer the structure of this setup.
92123
Things like the `docker-compose.yml` file or your Kubernetes or OpenShift configurations have to be adjusted as a consequence.
93-
Since April 2018 each image built from this repo contains a `NETBOX_DOCKER_PROJECT_VERSION` label.
94-
You can check the label of your local image by running `docker inspect netboxcommunity/netbox:v2.3.1 --format "{{json .ContainerConfig.Labels}}"`.
124+
Since November 2019 each image built from this repo contains a `org.opencontainers.image.version` label.
125+
(The images contained labels since April 2018, although in November 2019 the labels' names changed.)
126+
You can check the label of your local image by running `docker inspect netboxcommunity/netbox:v2.6.7 --format "{{json .ContainerConfig.Labels}}"`.
95127

96128
Please read [the release notes][releases] carefully when updating to a new image version.
97129

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.19.2
1+
0.19.4

0 commit comments

Comments
 (0)