Fixes #748: Ensure rack uniqueness (#751)

* Add location as standard query parameter in netbox_rack
* Adjust test to handle location as well
* More test adjustments. Add location to rack from the start

Author: rodvand

plugins/module_utils/netbox_utils.py

@@ -429,7 +429,7 @@
     "primary_ip6": set(["address", "vrf"]),
     "provider": set(["slug"]),
     "provider_network": set(["name"]),
-    "rack": set(["name", "site"]),
+    "rack": set(["name", "site", "location"]),
     "rack_group": set(["slug"]),
     "rack_role": set(["slug"]),
     "region": set(["slug"]),
@@ -467,6 +467,7 @@
         "device",
         "group",
         "interface",
+        "location",
         "rir",
         "vrf",
         "site",

tests/integration/targets/v2.11/tasks/netbox_rack.yml

@@ -11,6 +11,7 @@
     data:
       name: "Test rack one"
       site: "Test Site"
+      location: "Test Rack Group"
   register: test_one
 
 - name: "1 - ASSERT"
@@ -65,6 +66,7 @@
     data:
       name: Test rack one
       site: Test Site
+      location: "Test Rack Group"
     state: present
   register: test_four
 
@@ -109,7 +111,6 @@
       - test_five['diff']['after']['asset_tag'] == "1234"
       - test_five['diff']['after']['comments'] == "Just testing rack module"
       - test_five['diff']['after']['facility_id'] == "EQUI10291"
-      - test_five['diff']['after']['location'] == 1
       - test_five['diff']['after']['outer_depth'] == 24
       - test_five['diff']['after']['outer_unit'] == "in"
       - test_five['diff']['after']['outer_width'] == 32

tests/integration/targets/v3.0/tasks/netbox_rack.yml

@@ -11,6 +11,7 @@
     data:
       name: "Test rack one"
       site: "Test Site"
+      location: "Test Rack Group"
   register: test_one
 
 - name: "1 - ASSERT"
@@ -65,6 +66,7 @@
     data:
       name: Test rack one
       site: Test Site
+      location: "Test Rack Group"
     state: present
   register: test_four
 
@@ -109,7 +111,6 @@
       - test_five['diff']['after']['asset_tag'] == "1234"
       - test_five['diff']['after']['comments'] == "Just testing rack module"
       - test_five['diff']['after']['facility_id'] == "EQUI10291"
-      - test_five['diff']['after']['location'] == 1
       - test_five['diff']['after']['outer_depth'] == 24
       - test_five['diff']['after']['outer_unit'] == "in"
       - test_five['diff']['after']['outer_width'] == 32

tests/integration/targets/v3.1/tasks/netbox_rack.yml

@@ -11,6 +11,7 @@
     data:
       name: "Test rack one"
       site: "Test Site"
+      location: "Test Rack Group"
   register: test_one
 
 - name: "1 - ASSERT"
@@ -65,6 +66,7 @@
     data:
       name: Test rack one
       site: Test Site
+      location: "Test Rack Group"
     state: present
   register: test_four
 
@@ -109,7 +111,6 @@
       - test_five['diff']['after']['asset_tag'] == "1234"
       - test_five['diff']['after']['comments'] == "Just testing rack module"
       - test_five['diff']['after']['facility_id'] == "EQUI10291"
-      - test_five['diff']['after']['location'] == 1
       - test_five['diff']['after']['outer_depth'] == 24
       - test_five['diff']['after']['outer_unit'] == "in"
       - test_five['diff']['after']['outer_width'] == 32