BugFix: Convert keys in build_query_params (#86)

Author: FragmentedPacket

plugins/module_utils/netbox_utils.py

@@ -324,7 +324,7 @@
     "tenant_group": set(["name"]),
     "untagged_vlan": set(["name", "site", "vlan_group", "tenant"]),
     "virtual_machine": set(["name", "cluster"]),
-    "vlan": set(["name", "site", "tenant"]),
+    "vlan": set(["name", "site", "tenant", "vlan_group"]),
     "vlan_group": set(["slug", "site"]),
     "vrf": set(["name", "tenant"]),
 }
@@ -340,7 +340,6 @@
         "site",
         "tenant",
         "type",
-        "vlan_group",
         "virtual_machine",
     ]
 )
@@ -578,6 +577,7 @@ def _build_query_params(self, parent, module_data, child=None):
             else:
                 query_dict.update({"device": module_data["device"]})
 
+        query_dict = self._convert_identical_keys(query_dict)
         return query_dict
 
     def _change_choices_id(self, endpoint, data):

tests/unit/module_utils/test_netbox_base_class.py

@@ -3,10 +3,6 @@
 # Copyright: (c) 2019, Mikhail Yohman (@FragmentedPacket) <mikhail.yohman@gmail.com>
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
-# import unittest
-# from units.compat import unittest
-# from units.compat.mock import patch, MagicMock, Mock
-
 import pytest
 from unittest.mock import patch, MagicMock, Mock
 from ansible.module_utils.basic import AnsibleModule
@@ -803,7 +799,12 @@ def test_build_query_params_no_child(
                 "tenant": "Test Tenant",
                 "vlan_group": "Test VLAN group",
             },
-            {"name": "Test VLAN", "site_id": 1, "tenant_id": 1},
+            {
+                "name": "Test VLAN",
+                "site_id": 1,
+                "tenant_id": 1,
+                "group": "Test VLAN group",
+            },
         ),
         (
             "vlan_group",