Fixes #618 Ensure NetBox site module is idempotent between NetBox versions (#631)

* Change latitude/longitude to float in Netbox Site
* Change netbox_site to be idempotent between NetBox versions

Author: rodvand

plugins/module_utils/netbox_utils.py

@@ -1144,6 +1144,21 @@ def _update_netbox_object(self, data):
             serialized_nb_obj["tags"] = set(serialized_nb_obj["tags"])
             updated_obj["tags"] = set(data["tags"])
 
+        # Ensure idempotency for site on version pre-3.0
+        version_pre_30 = self._version_check_greater("3.0", self.version)
+        if (
+            serialized_nb_obj.get("latitude")
+            and data.get("latitude")
+            and version_pre_30
+        ):
+            updated_obj["latitude"] = str(data["latitude"])
+        if (
+            serialized_nb_obj.get("longitude")
+            and data.get("longitude")
+            and version_pre_30
+        ):
+            updated_obj["longitude"] = str(data["longitude"])
+
         if serialized_nb_obj == updated_obj:
             return serialized_nb_obj, None
         else:

plugins/modules/netbox_site.py

@@ -109,12 +109,12 @@
         description:
           - Latitude in decimal format
         required: false
-        type: str
+        type: float
       longitude:
         description:
           - Longitude in decimal format
         required: false
-        type: str
+        type: float
       contact_name:
         description:
           - Name of contact for site
@@ -267,8 +267,8 @@ def main():
                     description=dict(required=False, type="str"),
                     physical_address=dict(required=False, type="str"),
                     shipping_address=dict(required=False, type="str"),
-                    latitude=dict(required=False, type="str"),
-                    longitude=dict(required=False, type="str"),
+                    latitude=dict(required=False, type="float"),
+                    longitude=dict(required=False, type="float"),
                     contact_name=dict(required=False, type="str"),
                     contact_phone=dict(required=False, type="str"),
                     contact_email=dict(required=False, type="str"),