Bugfix: Removed logic to manipulate query params for ip_address (#421)

Author: FragmentedPacket

plugins/module_utils/netbox_utils.py

@@ -285,7 +285,7 @@
     "interface": set(["name", "device", "virtual_machine"]),
     "interface_template": set(["name", "device_type"]),
     "inventory_item": set(["name", "device"]),
-    "ip_address": set(["address", "vrf", "interface"]),
+    "ip_address": set(["address", "vrf", "device", "interface"]),
     "ip_addresses": set(["address", "vrf", "device", "interface"]),
     "ipaddresses": set(["address", "vrf", "device", "interface"]),
     "lag": set(["name"]),
@@ -701,17 +701,6 @@ def _build_query_params(
         elif parent == "prefix" and module_data.get("parent"):
             query_dict.update({"prefix": module_data["parent"]})
 
-        # This is for netbox_ipam and netbox_ip_address module
-        elif parent == "ip_address" and module_data.get("assigned_object_type"):
-            if module_data["assigned_object_type"] == "virtualization.vminterface":
-                query_dict.update(
-                    {"vminterface_id": module_data.get("assigned_object_id")}
-                )
-            elif module_data["assigned_object_type"] == "dcim.interface":
-                query_dict.update(
-                    {"interface_id": module_data.get("assigned_object_id")}
-                )
-
         elif parent == "ip_addresses":
             if isinstance(module_data["device"], int):
                 query_dict.update({"device_id": module_data["device"]})

tests/integration/targets/latest/tasks/netbox_ip_address.yml

@@ -316,7 +316,7 @@
       assigned_object:
         name: Eth0
         virtual_machine: test101-vm
-    state: "present"
+    state: "new"
   register: test_fifteen
 
 - name: "15 - ASSERT"

tests/integration/targets/v2.9/tasks/netbox_ip_address.yml

@@ -316,7 +316,7 @@
       assigned_object:
         name: Eth0
         virtual_machine: test101-vm
-    state: "present"
+    state: "new"
   register: test_fifteen
 
 - name: "15 - ASSERT"